[FTR] move supertestWithoutAuth service to kbn-ftr-common-functional-services #189613

dmlemeshko · 2024-07-31T09:54:19Z

Summary

While working on #188737 I had to move supertestWithoutAuth into kbn-ftr-common-functional-services package. This change seems to be bigger than initially planned.

Moving it to the separate PR with following changes:

move FTR SupertestWithoutAuthProvider service to package
remove "duplicates" in favour of service from package
update service type where needed

dmlemeshko · 2024-07-31T09:54:28Z

/ci

…package

dmlemeshko · 2024-07-31T12:19:05Z

/ci

… github.com:dmlemeshko/kibana into ftr/supertestWithoutAuth-to-common-services-package

dmlemeshko · 2024-07-31T12:30:03Z

/ci

…package

dmlemeshko · 2024-07-31T14:05:25Z

/ci

dmlemeshko · 2024-07-31T14:10:33Z

x-pack/test_serverless/api_integration/test_suites/common/console/proxy_route.ts

          .post('/api/console/proxy?method=GET&path=/.kibana/_settings')
          .set('kbn-xsrf', 'true')
          .set(svlCommonApi.getInternalRequestHeader())
-          .set(roleAuthc.apiKeyHeader)
-          .then((response) => {


Solving Parameter 'response' implicitly has an 'any' type.

Alternatively we can import Response type from supertest, but I believe we shouldn't import lib directly in test files. Open for discussion.

dmlemeshko · 2024-07-31T14:12:56Z

x-pack/test/saved_object_api_integration/common/services/index.ts

-  supertest: kibanaApiIntegrationServices.supertest,
-  supertestWithoutAuth: apiIntegrationServices.supertestWithoutAuth,
-  retry: kibanaApiIntegrationServices.retry,
-  esArchiver: kibanaFunctionalServices.esArchiver,
-  kibanaServer: kibanaFunctionalServices.kibanaServer,


already loaded as part of commonServices

dmlemeshko · 2024-07-31T14:13:13Z

x-pack/test/encrypted_saved_objects_api_integration/services.ts


 export const services = {
  ...commonServices,
-  supertestWithoutAuth: apiIntegrationServices.supertestWithoutAuth,


already loaded as part of commonServices

dmlemeshko · 2024-07-31T14:13:24Z

x-pack/test/api_integration/services/index.ts

@@ -36,7 +34,6 @@ export const services = {
  dataViewApi: DataViewApiProvider,
  esSupertestWithoutAuth: EsSupertestWithoutAuthProvider,
  infraOpsSourceConfiguration: InfraOpsSourceConfigurationProvider,
-  supertestWithoutAuth: SupertestWithoutAuthProvider,


already loaded as part of commonServices

…package

dmlemeshko · 2024-07-31T16:30:54Z

/ci

x-pack/test/spaces_api_integration/common/suites/copy_to_space.ts

… github.com:dmlemeshko/kibana into ftr/supertestWithoutAuth-to-common-services-package

…package

dmlemeshko · 2024-07-31T19:46:00Z

/ci

dmlemeshko · 2024-08-02T15:58:54Z

/ci

dmlemeshko · 2024-08-02T16:52:06Z

x-pack/test/spaces_api_integration/security_and_spaces/apis/create.ts

@@ -22,7 +23,7 @@ export default function createSpacesOnlySuite({ getService }: FtrProviderContext
    expectConflictResponse,
    expectRbacForbiddenResponse,
    expectSolutionSpecifiedResult,
-  } = createTestSuiteFactory(esArchiver, supertestWithoutAuth);
+  } = createTestSuiteFactory(esArchiver, supertestWithoutAuth as unknown as SuperTest<any>);


I had to do it to avoid test re-write: SupertestWithoutAuthProviderType won't allow to call .auth(string,string) with undefined arguments. I tried to rewrite it, but 2 configs started to fail, so I decide against it.

afharo

Core changes LGTM

elasticmachine · 2024-08-02T17:10:21Z

Pinging @elastic/fleet (Team:Fleet)

marius-dr

LGTM

pmuellr

ResponseOps changes LGTM

davismcphee

Data Discovery changes LGTM

sabarasaba

@elastic/kibana-management changes lgtm

…package

elena-shostak

LGTM!

kibana-ci · 2024-08-05T09:20:39Z

💚 Build Succeeded

Buildkite Build
Commit: ba1b370

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/ftr-common-functional-services`	21	24	+3

Unknown metric groups

API count

id	before	after	diff
`@kbn/ftr-common-functional-services`	36	39	+3

ESLint disabled line counts

id	before	after	diff
`@kbn/test-suites-serverless`	2	1	-1

Total ESLint disabled count

id	before	after	diff
`@kbn/test-suites-serverless`	3	2	-1

History

💚 Build #225630 succeeded 2a1198d
💔 Build #225600 failed 0df27f1
💔 Build #225155 failed 56c326d
💔 Build #225104 failed 557317a
💔 Build #225047 failed 0c071df
💔 Build #225013 failed d408fef

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dmlemeshko added 3 commits July 31, 2024 11:11

[ftr] move supertestWithoutAuth to kbn-ftr-common-functional-services

6e7508b

[x-pack/test] remove service copy and use one from package

6cd6adb

use unified type for supertestWithoutAuth

558cd8f

dmlemeshko added 2 commits July 31, 2024 14:17

fix types

66f2bf8

Merge branch 'main' into ftr/supertestWithoutAuth-to-common-services-…

45a6fc7

…package

dmlemeshko added 2 commits July 31, 2024 14:26

fix more tests

817740e

Merge branch 'ftr/supertestWithoutAuth-to-common-services-package' of…

d408fef

… github.com:dmlemeshko/kibana into ftr/supertestWithoutAuth-to-common-services-package

dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting FTR v8.16.0 labels Jul 31, 2024

dmlemeshko added 3 commits July 31, 2024 15:48

replace callback with await to fix 'any' type

c2471c1

call service inside mocha hook

c0762ec

Merge branch 'main' into ftr/supertestWithoutAuth-to-common-services-…

0c071df

…package

dmlemeshko commented Jul 31, 2024

View reviewed changes

dmlemeshko added 2 commits July 31, 2024 18:30

use wrapper to handle optional auth in supertest

a2cb31f

Merge branch 'main' into ftr/supertestWithoutAuth-to-common-services-…

557317a

…package

dmlemeshko commented Jul 31, 2024

View reviewed changes

x-pack/test/spaces_api_integration/common/suites/copy_to_space.ts Outdated Show resolved Hide resolved

dmlemeshko added 3 commits July 31, 2024 21:44

set Authorization header even if user is not defined

f0c511e

Merge branch 'ftr/supertestWithoutAuth-to-common-services-package' of…

ad2c6c7

… github.com:dmlemeshko/kibana into ftr/supertestWithoutAuth-to-common-services-package

Merge branch 'main' into ftr/supertestWithoutAuth-to-common-services-…

56c326d

…package

dmlemeshko mentioned this pull request Aug 2, 2024

[FTR] support "deployment agnostic" api-integration tests #188737

Closed

dmlemeshko commented Aug 2, 2024

View reviewed changes

dmlemeshko marked this pull request as ready for review August 2, 2024 17:02

dmlemeshko requested review from a team as code owners August 2, 2024 17:02

dmlemeshko requested a review from hop-dev August 2, 2024 17:02

afharo approved these changes Aug 2, 2024

View reviewed changes

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 2, 2024

jbudz approved these changes Aug 2, 2024

View reviewed changes

marius-dr approved these changes Aug 2, 2024

View reviewed changes

pmuellr approved these changes Aug 2, 2024

View reviewed changes

davismcphee approved these changes Aug 5, 2024

View reviewed changes

juliaElastic approved these changes Aug 5, 2024

View reviewed changes

sabarasaba approved these changes Aug 5, 2024

View reviewed changes

Merge branch 'main' into ftr/supertestWithoutAuth-to-common-services-…

ba1b370

…package

hop-dev approved these changes Aug 5, 2024

View reviewed changes

adcoelho approved these changes Aug 5, 2024

View reviewed changes

dmlemeshko enabled auto-merge (squash) August 5, 2024 08:12

elena-shostak approved these changes Aug 5, 2024

View reviewed changes

dmlemeshko merged commit 477d07f into elastic:main Aug 5, 2024
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FTR] move supertestWithoutAuth service to kbn-ftr-common-functional-services #189613

[FTR] move supertestWithoutAuth service to kbn-ftr-common-functional-services #189613

dmlemeshko commented Jul 31, 2024 •

edited

Loading

dmlemeshko commented Jul 31, 2024

dmlemeshko commented Jul 31, 2024

dmlemeshko commented Jul 31, 2024

dmlemeshko commented Jul 31, 2024

dmlemeshko Jul 31, 2024 •

edited

Loading

dmlemeshko Jul 31, 2024

dmlemeshko Jul 31, 2024

dmlemeshko Jul 31, 2024

dmlemeshko commented Jul 31, 2024

dmlemeshko commented Jul 31, 2024

dmlemeshko commented Aug 2, 2024

dmlemeshko Aug 2, 2024

afharo left a comment

elasticmachine commented Aug 2, 2024

marius-dr left a comment

pmuellr left a comment

davismcphee left a comment

sabarasaba left a comment

elena-shostak left a comment

kibana-ci commented Aug 5, 2024

API count

ESLint disabled line counts

Total ESLint disabled count

[FTR] move supertestWithoutAuth service to kbn-ftr-common-functional-services #189613

[FTR] move supertestWithoutAuth service to kbn-ftr-common-functional-services #189613

Conversation

dmlemeshko commented Jul 31, 2024 • edited Loading

Summary

dmlemeshko commented Jul 31, 2024

dmlemeshko commented Jul 31, 2024

dmlemeshko commented Jul 31, 2024

dmlemeshko commented Jul 31, 2024

dmlemeshko Jul 31, 2024 • edited Loading

Choose a reason for hiding this comment

dmlemeshko Jul 31, 2024

Choose a reason for hiding this comment

dmlemeshko Jul 31, 2024

Choose a reason for hiding this comment

dmlemeshko Jul 31, 2024

Choose a reason for hiding this comment

dmlemeshko commented Jul 31, 2024

dmlemeshko commented Jul 31, 2024

dmlemeshko commented Aug 2, 2024

dmlemeshko Aug 2, 2024

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

elasticmachine commented Aug 2, 2024

marius-dr left a comment

Choose a reason for hiding this comment

pmuellr left a comment

Choose a reason for hiding this comment

davismcphee left a comment

Choose a reason for hiding this comment

sabarasaba left a comment

Choose a reason for hiding this comment

elena-shostak left a comment

Choose a reason for hiding this comment

kibana-ci commented Aug 5, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

API count

ESLint disabled line counts

Total ESLint disabled count

History

dmlemeshko commented Jul 31, 2024 •

edited

Loading

dmlemeshko Jul 31, 2024 •

edited

Loading