Remove default_field from query:queryString:options #18966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16232
Fixes #15863
In 7.0 ES added a limit to the number of fields that can be queried. In 6.0 we started using default_field: * to get consistent highlighting in Discover even when a user had a mix of indices with and without an _all field. This is causing an issue with Beats pre-defined dashboards because the number of fields in a Beats index surpasses the query limit, yet we're telling it to query all fields. In 7.0, the _all field will be completely gone so we no longer really need the default_field setting. Let's remove it in 7.0.