Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Implements one-line pretty printing of the AST #189953

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Aug 6, 2024

Summary

Partially addresses #182257

Add a helper function, which given an ES|QL AST formats it to a one-line string.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@vadimkibana vadimkibana requested a review from a team as a code owner August 6, 2024 09:37
@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.16.0 labels Aug 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana enabled auto-merge (squash) August 6, 2024 11:59
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!

@vadimkibana vadimkibana merged commit 6bce745 into elastic:main Aug 6, 2024
33 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes review Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:ESQL ES|QL related features in Kibana v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants