Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screenshotting/7.17] Server package for stateless code #190246

Closed

Conversation

eokoneyo
Copy link
Contributor

@eokoneyo eokoneyo commented Aug 9, 2024

Summary

PR to investigate failing test run for #189326

Going of the failing test logs, the executable for linux headles chrome was being requested from the wrong path, see image below;

Screenshot 2024-08-12 at 09 28 47

@eokoneyo eokoneyo self-assigned this Aug 9, 2024
@eokoneyo eokoneyo force-pushed the fix/screenshotting/server-package-7.17 branch from 30ef0a8 to 35a32c0 Compare August 9, 2024 16:45
@eokoneyo
Copy link
Contributor Author

eokoneyo commented Aug 9, 2024

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6739

[✅] Default CI Group 4: 1/1 tests passed.

see run history

@eokoneyo eokoneyo force-pushed the fix/screenshotting/server-package-7.17 branch from 35a32c0 to 69fd5a0 Compare August 12, 2024 07:24
@eokoneyo
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/screenshotting-server - 25 +25
Unknown metric groups

API count

id before after diff
@kbn/screenshotting-server - 25 +25

History

  • 💔 Build #226872 failed 35a32c032dea8be9efaac7ec7bf0dbda7fb6a15c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @eokoneyo

@eokoneyo
Copy link
Contributor Author

eokoneyo commented Aug 12, 2024

closing in favor of tsullivan#15 , hypothesis about the executable path being wrong was correct and the fix has been extracted to be included in the PR aforementioned PR.

@eokoneyo eokoneyo closed this Aug 12, 2024
@eokoneyo eokoneyo deleted the fix/screenshotting/server-package-7.17 branch August 13, 2024 15:46
@eokoneyo eokoneyo restored the fix/screenshotting/server-package-7.17 branch August 20, 2024 13:13
@eokoneyo eokoneyo deleted the fix/screenshotting/server-package-7.17 branch August 20, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants