Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Fixes console error when creating ES|QL charts #190503

Merged
merged 1 commit into from
Aug 14, 2024
Merged

[ES|QL] Fixes console error when creating ES|QL charts #190503

merged 1 commit into from
Aug 14, 2024

Conversation

stratoula
Copy link
Contributor

Summary

Closes #190442

This is causing the error, as it is not needed. The abortController when passed to the search strategy is handled by it

@stratoula
Copy link
Contributor Author

/ci

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana labels Aug 14, 2024
@stratoula stratoula marked this pull request as ready for review August 14, 2024 14:53
@stratoula stratoula requested a review from a team as a code owner August 14, 2024 14:53
nickofthyme
nickofthyme approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@stratoula stratoula enabled auto-merge (squash) August 14, 2024 15:04
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / Case Owner Selection renders all options

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB -22.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 4d0cfdf into elastic:main Aug 14, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana Feature:Lens release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Milestone
No milestone
4 participants
@stratoula @kibana-ci @nickofthyme @kibanamachine