[Detection Engine] Fix timeline template popover not closing #190862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yctercero
added
release_note:skip
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
PhilippeOberti
approved these changes
Aug 28, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @yctercero |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 29, 2024
…#190862) ## Summary Addresses elastic#139263 Timeline template select was not closing on click - helper method was set to only open timeline template selection. (cherry picked from commit b5f5631)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 29, 2024
…190862) (#191694) # Backport This will backport the following commits from `main` to `8.15`: - [[Detection Engine] Fix timeline template popover not closing (#190862)](#190862) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yara Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-08-29T00:59:18Z","message":"[Detection Engine] Fix timeline template popover not closing (#190862)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/139263\r\n\r\nTimeline template select was not closing on click - helper method was\r\nset to only open timeline template selection.","sha":"b5f5631085263a923733f5b37760056c01515378","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detection Engine","v8.16.0","v8.15.1"],"title":"[Detection Engine] Fix timeline template popover not closing","number":190862,"url":"https://github.com/elastic/kibana/pull/190862","mergeCommit":{"message":"[Detection Engine] Fix timeline template popover not closing (#190862)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/139263\r\n\r\nTimeline template select was not closing on click - helper method was\r\nset to only open timeline template selection.","sha":"b5f5631085263a923733f5b37760056c01515378"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190862","number":190862,"mergeCommit":{"message":"[Detection Engine] Fix timeline template popover not closing (#190862)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/139263\r\n\r\nTimeline template select was not closing on click - helper method was\r\nset to only open timeline template selection.","sha":"b5f5631085263a923733f5b37760056c01515378"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #139263
Timeline template select was not closing on click - helper method was set to only open timeline template selection.
Fix
bug_fix.mov