Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Detection Engine] update alert assignment to disable unassign action if no assignees exist #190937

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Aug 21, 2024

Summary

Addresses #177864

Disables the unassign alert action if no assignees exist.

No assignee exists

Screenshot 2024-08-20 at 11 00 37 PM

Assignee exists

Screenshot 2024-08-20 at 11 01 00 PM

Checklist

@yctercero yctercero self-assigned this Aug 21, 2024
@yctercero yctercero requested review from a team as code owners August 21, 2024 03:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desk tested and code LGTM. Thanks for fixing this and adding tests!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 18.0MB 18.0MB +632.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit d673743 into elastic:main Aug 22, 2024
39 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 22, 2024
… if no assignees exist (elastic#190937)

## Summary

Addresses elastic#177864

Disables the unassign alert action if no assignees exist.

(cherry picked from commit d673743)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 22, 2024
… action if no assignees exist (#190937) (#191109)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Detection Engine] update alert assignment to disable unassign action
if no assignees exist
(#190937)](#190937)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yara
Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-08-22T15:54:12Z","message":"[Detection
Engine] update alert assignment to disable unassign action if no
assignees exist (#190937)\n\n## Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/177864\r\n\r\nDisables the
unassign alert action if no assignees
exist.","sha":"d673743aa422a079e75fd041513abfe3e0059074","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detection
Engine","v8.16.0","v8.15.1"],"title":"[Detection Engine] update alert
assignment to disable unassign action if no assignees
exist","number":190937,"url":"https://github.com/elastic/kibana/pull/190937","mergeCommit":{"message":"[Detection
Engine] update alert assignment to disable unassign action if no
assignees exist (#190937)\n\n## Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/177864\r\n\r\nDisables the
unassign alert action if no assignees
exist.","sha":"d673743aa422a079e75fd041513abfe3e0059074"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190937","number":190937,"mergeCommit":{"message":"[Detection
Engine] update alert assignment to disable unassign action if no
assignees exist (#190937)\n\n## Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/177864\r\n\r\nDisables the
unassign alert action if no assignees
exist.","sha":"d673743aa422a079e75fd041513abfe3e0059074"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants