Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add toggles for agent.monitoring.http.enabled and agent.monitoring.http.buffer.enabled to agent policy advanced settings #190984

Merged

Conversation

kpollich
Copy link
Member

Summary

Ref #180922

Re-add the agent.monitoring.enabled and agent.monitoring.buffer.enabled settings under Agent Policy -> Advanced Settings.

cc @pierrehilbert

@kpollich kpollich added release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 21, 2024
@kpollich kpollich self-assigned this Aug 21, 2024
@kpollich kpollich requested a review from a team as a code owner August 21, 2024 12:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Just to check the wanted fields are agent.monitoring.http.enabled and agent.monitoring.http.buffer.enabled ? The PR title do not contains the http part

@kpollich kpollich changed the title [Fleet] Add toggles for agent.monitoring.enabled and agent.monitoring.buffer.enabled to agent policy advanced settings [Fleet] Add toggles for agent.monitoring.http.enabled and agent.monitoring.http.buffer.enabled to agent policy advanced settings Aug 21, 2024
@kpollich
Copy link
Member Author

LGTM 🚀

Just to check the wanted fields are agent.monitoring.http.enabled and agent.monitoring.http.buffer.enabled ? The PR title do not contains the http part

Good catch - I updated the title so the eventual release notes are accurate.

@kpollich kpollich enabled auto-merge (squash) August 21, 2024 13:26
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #61 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Prebuilt Rules status get_prebuilt_rules_status should return empty structure when no prebuilt rule assets
  • [job] [logs] FTR Configs #69 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Prebuilt Rules status get_prebuilt_rules_status should return empty structure when no prebuilt rule assets

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +124.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 8b7de03 into elastic:main Aug 21, 2024
30 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants