Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet UI] Set flag for traces in Agent policy's monitoring configuration #191139

Merged

Conversation

ycombinator
Copy link
Contributor

Summary

This PR sets the traces boolean flag in an Agent policy's monitoring configuration if traces was included in the monitoring_enabled array.

@ycombinator ycombinator added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 22, 2024
@ycombinator ycombinator requested a review from a team as a code owner August 22, 2024 20:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ycombinator ycombinator requested a review from nchaulet August 22, 2024 20:43
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@ycombinator ycombinator added the release_note:skip Skip the PR/issue when compiling release notes label Aug 22, 2024
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM 🚀 looks like there is some formatting to fix

Screenshot 2024-08-23 at 8 09 08 AM

@ycombinator ycombinator force-pushed the fleet-agent-policy-enable-tracing branch from 60e7bcb to 1235271 Compare August 23, 2024 22:38
@ycombinator ycombinator requested a review from nchaulet August 23, 2024 22:38
@ycombinator
Copy link
Contributor Author

@nchaulet I changed a lot more files, mostly to make tests pass, after your LGTM so I'd like you to take another look, if you don't mind. Thanks.

@ycombinator ycombinator enabled auto-merge (squash) August 26, 2024 18:37
@ycombinator ycombinator force-pushed the fleet-agent-policy-enable-tracing branch from 1235271 to 68464b9 Compare August 26, 2024 18:37
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #94 / discover/context_awareness extension getDefaultAppState data view mode should render default columns and row height

Metrics [docs]

✅ unchanged

History

  • 💚 Build #229602 succeeded 12352715930fb58548df9283f76aea91bf45b984
  • 💔 Build #229588 failed 60e7bcbb50d63638b3675577b50726c99adbfd29
  • 💔 Build #229572 failed b3fd672a33b4800ad9becc9a2932b7eeba78ec8b
  • 💔 Build #229471 failed 13e7c5493f0d0af90c1b0f818ed0743b9e8a9b12
  • 💔 Build #229464 failed 7623bdfbffac9371a03cd38174954323cc13f2d8
  • 💔 Build #229443 failed 852ae54f636cc407e187b4ecd210afef3b0c5c3f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ycombinator ycombinator merged commit d1cc0cb into elastic:main Aug 26, 2024
25 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 26, 2024
@ycombinator ycombinator deleted the fleet-agent-policy-enable-tracing branch August 26, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants