Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OAS][DOCS] Add feedback links for Kibana APIs #191145

Merged
merged 1 commit into from
Aug 23, 2024
Merged

[OAS][DOCS] Add feedback links for Kibana APIs #191145

merged 1 commit into from
Aug 23, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 22, 2024 •
edited by kibanamachine
Loading

Summary

This PR:

@lcawl lcawl added Team:Docs release_note:skip Skip the PR/issue when compiling release notes docs backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Aug 22, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review August 22, 2024 22:15
@lcawl lcawl requested a review from a team as a code owner August 22, 2024 22:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

georgewallace
georgewallace approved these changes Aug 23, 2024
View reviewed changes
Copy link

@georgewallace georgewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 0770e94 into elastic:main Aug 23, 2024
25 checks passed
@lcawl lcawl deleted the api-feedback branch August 23, 2024 20:46
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 191145

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl mentioned this pull request Aug 23, 2024
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request Aug 23, 2024
@lcawl
[OAS][DOCS] Add feedback links for Kibana APIs (elastic#191145)
c1c61bb 
(cherry picked from commit 0770e94)
@lcawl
Copy link
Contributor Author

lcawl commented Aug 23, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Aug 23, 2024
@lcawl
[8.15] [OAS][DOCS] Add feedback links for Kibana APIs (#191145) (#191231
95911bd 
)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[OAS][DOCS] Add feedback links for Kibana APIs
(#191145)](#191145)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2024-08-23T20:46:12Z","message":"[OAS][DOCS]
Add feedback links for Kibana APIs
(#191145)","sha":"0770e947e27ddbc7ebc5fe6ad19e59b60ac335e1","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","backport:prev-minor","v8.16.0"],"number":191145,"url":"https://github.com/elastic/kibana/pull/191145","mergeCommit":{"message":"[OAS][DOCS]
Add feedback links for Kibana APIs
(#191145)","sha":"0770e947e27ddbc7ebc5fe6ad19e59b60ac335e1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191145","number":191145,"mergeCommit":{"message":"[OAS][DOCS]
Add feedback links for Kibana APIs
(#191145)","sha":"0770e947e27ddbc7ebc5fe6ad19e59b60ac335e1"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KOTungseth KOTungseth KOTungseth approved these changes

@georgewallace georgewallace georgewallace approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.15.1 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lcawl @obltmachine @elasticmachine @kibana-ci @kibanamachine @georgewallace @KOTungseth