Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Handle Detection Rules and Benchmark rules errors #191150

Merged
merged 9 commits into from
Aug 23, 2024

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented Aug 23, 2024

Summary

This PR addresses the following:

  • Handling errors when creating Detection rules
  • Handling errors when muting/unmuting Benchmark rules
  • Handling Alerts pending on loading state when the user doesn't have read permission to the Detection Rules alerts index (.alerts-security.alerts-default).
  • Centralized benchmark rules mutation success/error logic in the useChangeCspRuleState hook.
  • Fixed benchmark mute API that was disabling only one detection rule per benchmark rule.

Recordings

Read Only User (Without .alerts-security.alerts-default read permission)

Screen.Recording.2024-08-22.at.6.21.30.PM.mov

Read Only User (With .alerts-security.alerts-default read permission)

Screen.Recording.2024-08-22.at.6.44.11.PM.mov

Write permission user

Screen.Recording.2024-08-22.at.6.38.11.PM.mov

@opauloh opauloh added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.16.0 labels Aug 23, 2024
@opauloh opauloh requested a review from a team as a code owner August 23, 2024 01:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 480.3KB 480.5KB +225.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@opauloh opauloh merged commit 2595182 into elastic:main Aug 23, 2024
19 checks passed
@opauloh opauloh deleted the quick-wins/rules-error-handling branch August 23, 2024 22:44
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants