Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] fix flaky test with deleting filters #191316

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Aug 26, 2024

Summary

Fixes #191009

(also fixes #189569 #178270 #139040 which are already closed as one time occurances but could happen again)

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6809

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.16.0 labels Aug 26, 2024
@mbondyra mbondyra marked this pull request as ready for review August 26, 2024 21:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #11 / rules_list component empty hides MaintenanceWindowCallout if filterConsumers does not match the running maintenance window's category

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6809

[✅] x-pack/test/functional/apps/lens/group1/config.ts: 200/200 tests passed.

see run history

@mbondyra mbondyra requested a review from a team August 27, 2024 08:58
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@mbondyra mbondyra merged commit b5570ec into elastic:main Aug 27, 2024
25 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 27, 2024
@mbondyra mbondyra deleted the lens/flaky_tests_fix branch August 27, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment