Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix check for pre-emption failure #191325

Merged
merged 4 commits into from
Aug 27, 2024
Merged

[ci] Fix check for pre-emption failure #191325

merged 4 commits into from
Aug 27, 2024

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Aug 26, 2024 •
edited by kibanamachine
Loading

null

@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes labels Aug 26, 2024
mistic
mistic reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it a good idea to check both for spot=true and preemptible=true as Spot VMs are the latest version of preemptible VMs?

@jbudz
Copy link
Member Author

jbudz commented Aug 27, 2024

Isn't it a good idea to check both for spot=true and preemptible=true as Spot VMs are the latest version of preemptible VMs?

I don't follow entirely, can you help me understand?

@jbudz jbudz marked this pull request as ready for review August 27, 2024 13:00
@jbudz jbudz requested a review from a team as a code owner August 27, 2024 13:00
@jbudz
Copy link
Member Author

jbudz commented Aug 27, 2024

buildkite test this

@mistic
Copy link
Member

mistic commented Aug 27, 2024

We just chatted offline about this. We are going to check if this metadata fields are static and internal populated or being redirected from whatever gcp has

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz added the backport:all-open Backport to all branches that could still receive a release label Aug 27, 2024
@jbudz jbudz merged commit 03ba36a into elastic:main Aug 27, 2024
20 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 27, 2024
@jbudz
[ci] Fix check for pre-emption failure (elastic#191325)
b89c4a4 
(cherry picked from commit 03ba36a)
@kibanamachine kibanamachine mentioned this pull request Aug 27, 2024
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 191325

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 27, 2024
@kibanamachine @jbudz
[8.15] [ci] Fix check for pre-emption failure (#191325) (#191555)
c30360d 
# Backport

This will backport the following commits from `main` to `8.15`:
- [[ci] Fix check for pre-emption failure
(#191325)](#191325)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2024-08-27T21:08:45Z","message":"[ci]
Fix check for pre-emption failure
(#191325)","sha":"03ba36a0287f72fa6ebf50e26675183c575bcd15","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.16.0"],"title":"[ci]
Fix check for pre-emption
failure","number":191325,"url":"https://github.com/elastic/kibana/pull/191325","mergeCommit":{"message":"[ci]
Fix check for pre-emption failure
(#191325)","sha":"03ba36a0287f72fa6ebf50e26675183c575bcd15"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191325","number":191325,"mergeCommit":{"message":"[ci]
Fix check for pre-emption failure
(#191325)","sha":"03ba36a0287f72fa6ebf50e26675183c575bcd15"}}]}]
BACKPORT-->

Co-authored-by: Jon <jon@elastic.co>
This was referenced Aug 27, 2024
Merged
Merged
jbudz added a commit that referenced this pull request Aug 28, 2024
@jbudz
[7.17] [ci] Fix check for pre-emption failure (#191325) (#191560)
c21aac1 
#191325
elastic/kibana-buildkite-library@7eff716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic left review comments

@delanni delanni delanni approved these changes

Assignees
No one assigned
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.15.1 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbudz @mistic @kibana-ci @kibanamachine @delanni