[Fleet] Allow exclamation mark in enrollment token name

[jillguyonnet]

Summary

Closes #191719

Attempting to generate a Fleet enrollment token with a name that ends with ! produces a malformed ES query which causes POST agents/enrollment_api_keys to fail with 500.

This PR adds a narrow fix by escaping question marks (which is a query_string special character).

Note: this query probably wouldn't be necessary if we removed the constraint of unique name, as discussed in #155550.

[obltmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[juliaElastic]

LGTM, are there any other special characters that we should escape?

[jillguyonnet]

Thanks @juliaElastic!

There is a list of special characters: https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html#query-string-syntax. I tried them all, most work besides some fairly unusual ones (&& for example). I thought about making a more robust function, but I wasn't sure the effort would be worth it considering we might eventually lift the name uniqueness constraint. WDYT?

[juliaElastic]

There is a list of special characters: https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html#query-string-syntax. I tried them all, most work besides some fairly unusual ones (&& for example). I thought about making a more robust function, but I wasn't sure the effort would be worth it considering we might eventually lift the name uniqueness constraint. WDYT?

I agree, probably not worth putting more effort now. Thanks for confirming.

[jillguyonnet]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 2a55742

Metrics [docs]

✅ unchanged

History

• 💔 Build #231046 failed 729aa9a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jillguyonnet