[Management] Saved objects UI should use the Saved Objects client #19193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be clear, this isn’t strictly about RBAC. It’s about supporting all of the capabilities that the saved object abstraction provides, like seamless major version upgrades/migrations/pluggability for things like tags/etc. |
chrisronline
changed the title
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
jen-huang
approved these changes
May 18, 2018
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 18, 2018
…astic#19193) * Ensure we always go through the saved objects client * Fix a couple UI glitches * Update these tests too * Update snapshots
|
Backport: 6.x: 7e0e77b |
epixa
added a commit
to epixa/kibana
that referenced
this pull request
May 19, 2018
…ient (elastic#19193)" This reverts commit fcec107.
epixa
added a commit
to epixa/kibana
that referenced
this pull request
May 19, 2018
…ient (elastic#19193) (elastic#19227)" This reverts commit 7e0e77b.
epixa
added a commit
to epixa/kibana
that referenced
this pull request
May 19, 2018
…ient (elastic#19193)" This reverts commit fcec107.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19185
#17426 brought in a few poor choices of how to query for saved objects, notably going outside of the saved objects api. This PR addresses that. There should be no functional changes.
cc @kobelb