Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v95.10.1 #192026

Merged
merged 22 commits into from
Sep 10, 2024
Merged

Upgrade EUI to v95.10.1 #192026

merged 22 commits into from
Sep 10, 2024

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Sep 3, 2024

v95.9.0v95.10.1

Note

EuiDataGrid's header cells have received a major UX change in order to support interactive children within header content. Column header actions now must be hovered and then clicked directly, or opened with the Enter key, as opposed to being able to click the entire header cell to see the actions popover.

Questions? Please see our Kibana upgrade FAQ.


v95.10.0

  • Updated EuiDataGrid to support interactive header cell content (#7898)
  • Updated EuiSearchBar's field_value_selection filter type with a new autoSortOptions config, allowing consumers to configure whether or not selected options are automatically sorted to the top of the filter list (#7958)
  • Updated getDefaultEuiMarkdownPlugins to support the following new default plugin configurations: (#7985)
    • parsingConfig.linkValidator, which allows configuring allowRelative and allowProtocols
    • parsingConfig.emoji, which allows configuring emoticon parsing
    • processingConfig.linkProps, which allows configuring rendered links with any props that EuiLink accepts
    • See our Markdown plugins documentation for example EuiMarkdownFormat and EuiMarkdownEditor usage
  • Updated EuiDatePicker to support append and prepend nodes in its form control layout (#7987)

Bug fixes

  • Fixed border rendering bug with inline EuiDatePickers with shadow={false} (#7987)
  • Fixed EuiSuperSelect's placeholder text color to match other form controls (#7995)

Accessibility

  • Improved the keyboard navigation and screen reader output for EuiDataGrid header cells (#7898)

v95.10.1

Bug fixes

  • Fixed a visual bug in compact density EuiDataGrids, where the header cell height would increase when the actions button became visible (#7999)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.16.0 labels Sep 3, 2024
cee-chen and others added 13 commits September 3, 2024 14:18
- not all of them, just the oens related to header column actions in this PR. someone on the owning Kibana team should likely look into resolving all of them

- errors were `Warning: An update to DataTable inside a test was not wrapped in act(...).` and `Warning: Can't perform a React state update on an unmounted component`
…ons button changes

+ fix misc failing test to use said service
…counts for header changes

+ add new util for default "Hide columns" copy
…king any action at an index

+ add new util for default "Hide columns" copy
ensures test order instead, as opened flyout contains a standalone datagrid the column header test assertion should happen on a state with only the first datagrid
@cee-chen cee-chen changed the title Upgrade EUI to v95.10.0 Upgrade EUI to v95.10.1 Sep 4, 2024
@cee-chen cee-chen marked this pull request as ready for review September 4, 2024 20:39
@cee-chen cee-chen requested review from a team as code owners September 4, 2024 20:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 4, 2024
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs-ux-management code change looks good to me!

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and visual check, good for me

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes look good, and everything seems to be working as expected in Discover 👍 Thanks for making the data grid header change, this unblocks some planned changes for us!

@cee-chen
Copy link
Member Author

cee-chen commented Sep 9, 2024

@elastic/kibana-core @elastic/security-threat-hunting-investigations Ping for codeowning review - we will be requesting an admin merge by today or tomorrow.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 10, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 68bfbc2
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192026-68bfbc297332

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / FormBasedDimensionEditor should list all field names and document as a whole in prioritized order

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 418.2KB 418.6KB +393.0B
kbnUiSharedDeps-css 147.6KB 148.7KB +1.1KB
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +2.1KB
total +3.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 20566d0 into elastic:main Sep 10, 2024
39 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 10, 2024
@cee-chen cee-chen deleted the eui/v95.10.0 branch September 10, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project EUI release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants