-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v95.10.1 #192026
Upgrade EUI to v95.10.1 #192026
Conversation
- not all of them, just the oens related to header column actions in this PR. someone on the owning Kibana team should likely look into resolving all of them - errors were `Warning: An update to DataTable inside a test was not wrapped in act(...).` and `Warning: Can't perform a React state update on an unmounted component`
…ons button changes + fix misc failing test to use said service
…counts for header changes + add new util for default "Hide columns" copy
…king any action at an index + add new util for default "Hide columns" copy
…e mouse is inside header column
ensures test order instead, as opened flyout contains a standalone datagrid the column header test assertion should happen on a state with only the first datagrid
Pinging @elastic/eui-team (EUI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obs-ux-management code change looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and visual check, good for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Discovery changes look good, and everything seems to be working as expected in Discover 👍 Thanks for making the data grid header change, this unblocks some planned changes for us!
@elastic/kibana-core @elastic/security-threat-hunting-investigations Ping for codeowning review - we will be requesting an admin merge by today or tomorrow. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
v95.9.0
⏩v95.10.1
Note
EuiDataGrid's header cells have received a major UX change in order to support interactive children within header content. Column header actions now must be hovered and then clicked directly, or opened with the Enter key, as opposed to being able to click the entire header cell to see the actions popover.
Questions? Please see our Kibana upgrade FAQ.
v95.10.0
EuiDataGrid
to support interactive header cell content (#7898)EuiSearchBar
'sfield_value_selection
filter type with a newautoSortOptions
config, allowing consumers to configure whether or not selected options are automatically sorted to the top of the filter list (#7958)getDefaultEuiMarkdownPlugins
to support the following new default plugin configurations: (#7985)parsingConfig.linkValidator
, which allows configuringallowRelative
andallowProtocols
parsingConfig.emoji
, which allows configuring emoticon parsingprocessingConfig.linkProps
, which allows configuring rendered links with any props thatEuiLink
acceptsEuiMarkdownFormat
andEuiMarkdownEditor
usageEuiDatePicker
to supportappend
andprepend
nodes in its form control layout (#7987)Bug fixes
EuiDatePicker
s withshadow={false}
(#7987)EuiSuperSelect
's placeholder text color to match other form controls (#7995)Accessibility
EuiDataGrid
header cells (#7898)v95.10.1
Bug fixes
EuiDataGrid
s, where the header cell height would increase when the actions button became visible (#7999)