Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix add panels order of items !! #192082

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 4, 2024

Summary

Fixes part of #190853 !!

Combines synthetics and SLO embeddables under common observability group !!

After

image

Before

image

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 marked this pull request as ready for review September 4, 2024 12:57
@shahzad31 shahzad31 requested review from a team as code owners September 4, 2024 12:57
@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Sep 4, 2024
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Sep 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 4, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 84b4248
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192082-84b42488c334

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityShared 205 206 +1
slo 840 839 -1
total -0

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityShared 451 452 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 852.2KB 852.1KB -41.0B
synthetics 938.8KB 938.9KB +62.0B
total +21.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityShared 69.2KB 69.5KB +260.0B
synthetics 37.0KB 36.8KB -211.0B
total +49.0B
Unknown metric groups

API count

id before after diff
observabilityShared 456 457 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit fabe07d into elastic:main Sep 5, 2024
24 checks passed
@shahzad31 shahzad31 deleted the fix-dashboard-order branch September 5, 2024 08:18
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Sep 5, 2024
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants