Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Provide cleaner text selection for the grid #192395

Closed
wants to merge 16 commits into from

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Sep 9, 2024

Summary

With this PR the copied selection of a data grid will be cleaner and in TSV format. It is improved for the following views:

  • Discover grid
  • Discover DocViewer
  • Discover Surrounding Documents page
  • Discover Single Document page
  • Dashboard with a search panel
  • O11y Log Explorer
  • Security timeline

Sep-09-2024 19-01-24

Checklist

@jughosta jughosta added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedDataTable labels Sep 9, 2024
@jughosta jughosta self-assigned this Sep 9, 2024
@jughosta jughosta added release_note:enhancement backport:skip This commit does not require backporting labels Sep 12, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1291 1292 +1
cloudSecurityPosture 647 648 +1
discover 994 995 +1
esqlDataGrid 363 364 +1
eventAnnotationListing 578 579 +1
lens 1454 1455 +1
logsExplorer 562 563 +1
observability 1056 1057 +1
securitySolution 5758 5759 +1
slo 844 845 +1
unifiedDocViewer 215 216 +1
total +11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/discover-utils 138 140 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 496.1KB 497.9KB +1.9KB
discover 811.2KB 813.0KB +1.9KB
esqlDataGrid 152.8KB 154.7KB +1.9KB
securitySolution 20.3MB 20.3MB +9.4KB
slo 852.3KB 854.2KB +1.9KB
unifiedDocViewer 120.9KB 122.8KB +1.9KB
total +18.8KB
Unknown metric groups

API count

id before after diff
@kbn/discover-utils 172 174 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta marked this pull request as ready for review September 12, 2024 15:46
@jughosta jughosta requested review from a team as code owners September 12, 2024 15:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta
Copy link
Contributor Author

Closing in favor of Eui PR elastic/eui#8019

@jughosta jughosta closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:UnifiedDataTable release_note:enhancement Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove new lines when copy/pasting in Discover
3 participants