Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Alerting] fix alert conflict resolution to support create #192534

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Sep 11, 2024

resolves: #190376

In PR #160572, we changed from using just the bulk op index to using create when new alerts are being created.

Unfortunately, the code to handle the bulk responses didn't take into account that the bulk responses for creates need different handling than indexs. Specifically, conflicts for create were being treated as errors.

This PR changes the processing to consider additional ops besides just index.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 11, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

@pmuellr pmuellr force-pushed the 190376-create-is-a-conflict branch from 10b964a to bd4cf3d Compare September 26, 2024 18:55
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #43 / discover/esql discover esql view ES|QL in Discover should render esql view correctly

Metrics [docs]

✅ unchanged

History

  • 💛 Build #233299 was flaky 10b964a63b6d584bc32992096801efc6c6aba062

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pmuellr pmuellr force-pushed the 190376-create-is-a-conflict branch from ea2cecc to 46622c2 Compare October 15, 2024 22:27
resolves: elastic#190376

In PR elastic#160572, we changed from
using just the bulk op `index` to using `create` when new alerts are
being created.

Unfortunately, the code to handle the bulk responses didn't take into
account that the bulk responses for `create`s need different handling
than `index`s.  Specifically, conflicts for `create` were being treated
as errors.

This PR changes the processing to consider additional ops besides just
`index`.
@pmuellr pmuellr force-pushed the 190376-create-is-a-conflict branch from 46622c2 to e7b6311 Compare December 10, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ResponseOps][Alerting] alert updates not recognizing document conflicts
3 participants