Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev/precommitHook] log all failures, don't stop at first #19271

Merged
merged 4 commits into from
Jun 22, 2018
Merged

[dev/precommitHook] log all failures, don't stop at first #19271

merged 4 commits into from
Jun 22, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 21, 2018

As pointed out in #19105, if there are multiple failures in the precommit hook only the first failure is logged. Instead, this implementation collects the errors rom all tasks and ensures that all are logged.

Perhaps once #19105 goes in we can migrate this to use listr and merge errors that way.

@spalger spalger added review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.4.0 labels May 21, 2018
@spalger spalger requested a review from epixa May 21, 2018 19:23
@spalger spalger mentioned this pull request May 21, 2018
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@epixa
Copy link
Contributor

epixa commented May 24, 2018

You have conflicts here

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor Author

spalger commented May 24, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger
Copy link
Contributor Author

spalger commented Jun 18, 2018

@epixa can you take a look at this?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor Author

spalger commented Jun 18, 2018

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@epixa
Copy link
Contributor

epixa commented Jun 19, 2018

@spalger Yep, I will take a look, but it won't be for a couple of days. I'm working through some higher priority PRs first.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

epixa
epixa approved these changes Jun 22, 2018
View reviewed changes
Copy link
Contributor

@epixa epixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit d9b3171 into elastic:master Jun 22, 2018
@spalger spalger mentioned this pull request Jun 22, 2018
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Jun 22, 2018
[dev/precommitHook] log all failures, don't stop at first (elastic#19271
87e1664 
)
spalger pushed a commit that referenced this pull request Jun 22, 2018
[6.x] [dev/precommitHook] log all failures, don't stop at first (#19271…
c6a9b3c 
…) (#20170)

Backports the following commits to 6.x:
 - [dev/precommitHook] log all failures, don't stop at first  (#19271)
@spalger
Copy link
Contributor Author

spalger commented Jun 22, 2018

6.x/6.4: c6a9b3c

@spalger spalger deleted the implement/multiple-precommit-failures branch June 22, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epixa epixa epixa approved these changes

Assignees
No one assigned
Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalger @elasticmachine @epixa