[UII] Make constant keyword backfill optional #192921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
nchaulet
approved these changes
Sep 13, 2024
|
@nchaulet I added a few unit tests here :) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @jen-huang |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 14, 2024
## Summary Follow up to elastic#188145. In some edge cases (elastic/sdh-beats#5156), users could override the index template used by integration data streams. It is possible to create an index template without mappings, this causes `fillConstantKeywordValues` to receive an undefined object when upgrading the integration, and the upgrade then fails. This PR makes the backfill operation here more fail-safe. (cherry picked from commit b5abc4e)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 14, 2024
## Summary Follow up to elastic#188145. In some edge cases (elastic/sdh-beats#5156), users could override the index template used by integration data streams. It is possible to create an index template without mappings, this causes `fillConstantKeywordValues` to receive an undefined object when upgrading the integration, and the upgrade then fails. This PR makes the backfill operation here more fail-safe. (cherry picked from commit b5abc4e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 14, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[UII] Make constant keyword backfill optional (#192921)](#192921) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"its.jenetic@gmail.com"},"sourceCommit":{"committedDate":"2024-09-14T02:34:46Z","message":"[UII] Make constant keyword backfill optional (#192921)\n\n## Summary\r\n\r\nFollow up to #188145. In some edge cases\r\n(elastic/sdh-beats#5156), users could override\r\nthe index template used by integration data streams. It is possible to\r\ncreate an index template without mappings, this causes\r\n`fillConstantKeywordValues` to receive an undefined object when\r\nupgrading the integration, and the upgrade then fails.\r\n\r\nThis PR makes the backfill operation here more fail-safe.","sha":"b5abc4ec7e308815b0f338f4c836a9caf3ee48a3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"[UII] Make constant keyword backfill optional","number":192921,"url":"https://github.com/elastic/kibana/pull/192921","mergeCommit":{"message":"[UII] Make constant keyword backfill optional (#192921)\n\n## Summary\r\n\r\nFollow up to #188145. In some edge cases\r\n(elastic/sdh-beats#5156), users could override\r\nthe index template used by integration data streams. It is possible to\r\ncreate an index template without mappings, this causes\r\n`fillConstantKeywordValues` to receive an undefined object when\r\nupgrading the integration, and the upgrade then fails.\r\n\r\nThis PR makes the backfill operation here more fail-safe.","sha":"b5abc4ec7e308815b0f338f4c836a9caf3ee48a3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192921","number":192921,"mergeCommit":{"message":"[UII] Make constant keyword backfill optional (#192921)\n\n## Summary\r\n\r\nFollow up to #188145. In some edge cases\r\n(elastic/sdh-beats#5156), users could override\r\nthe index template used by integration data streams. It is possible to\r\ncreate an index template without mappings, this causes\r\n`fillConstantKeywordValues` to receive an undefined object when\r\nupgrading the integration, and the upgrade then fails.\r\n\r\nThis PR makes the backfill operation here more fail-safe.","sha":"b5abc4ec7e308815b0f338f4c836a9caf3ee48a3"}}]}] BACKPORT--> Co-authored-by: Jen Huang <its.jenetic@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Sep 14, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [[UII] Make constant keyword backfill optional (#192921)](#192921) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"its.jenetic@gmail.com"},"sourceCommit":{"committedDate":"2024-09-14T02:34:46Z","message":"[UII] Make constant keyword backfill optional (#192921)\n\n## Summary\r\n\r\nFollow up to #188145. In some edge cases\r\n(elastic/sdh-beats#5156), users could override\r\nthe index template used by integration data streams. It is possible to\r\ncreate an index template without mappings, this causes\r\n`fillConstantKeywordValues` to receive an undefined object when\r\nupgrading the integration, and the upgrade then fails.\r\n\r\nThis PR makes the backfill operation here more fail-safe.","sha":"b5abc4ec7e308815b0f338f4c836a9caf3ee48a3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"[UII] Make constant keyword backfill optional","number":192921,"url":"https://github.com/elastic/kibana/pull/192921","mergeCommit":{"message":"[UII] Make constant keyword backfill optional (#192921)\n\n## Summary\r\n\r\nFollow up to #188145. In some edge cases\r\n(elastic/sdh-beats#5156), users could override\r\nthe index template used by integration data streams. It is possible to\r\ncreate an index template without mappings, this causes\r\n`fillConstantKeywordValues` to receive an undefined object when\r\nupgrading the integration, and the upgrade then fails.\r\n\r\nThis PR makes the backfill operation here more fail-safe.","sha":"b5abc4ec7e308815b0f338f4c836a9caf3ee48a3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192921","number":192921,"mergeCommit":{"message":"[UII] Make constant keyword backfill optional (#192921)\n\n## Summary\r\n\r\nFollow up to #188145. In some edge cases\r\n(elastic/sdh-beats#5156), users could override\r\nthe index template used by integration data streams. It is possible to\r\ncreate an index template without mappings, this causes\r\n`fillConstantKeywordValues` to receive an undefined object when\r\nupgrading the integration, and the upgrade then fails.\r\n\r\nThis PR makes the backfill operation here more fail-safe.","sha":"b5abc4ec7e308815b0f338f4c836a9caf3ee48a3"}}]}] BACKPORT--> Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #188145. In some edge cases (https://github.com/elastic/sdh-beats/issues/5156), users could override the index template used by integration data streams. It is possible to create an index template without mappings, this causes
fillConstantKeywordValuesto receive an undefined object when upgrading the integration, and the upgrade then fails.This PR makes the backfill operation here more fail-safe.