Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Amend inventory title to "Infrastructure Inventory" #193189

Merged
merged 9 commits into from
Sep 20, 2024
29 changes: 25 additions & 4 deletions x-pack/plugins/observability_solution/infra/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,17 +163,38 @@ export class Plugin implements InfraClientPluginClass {
...(capabilities.infrastructure.show
? [
{
label: 'Infrastructure',
label: i18n.translate('xpack.infra.metrics.pluginTitle', {
defaultMessage: 'Infrastructure',
}),
sortKey: 300,
entries: [
{ label: 'Inventory', app: 'metrics', path: '/inventory' },
{
label: i18n.translate(
'xpack.infra.metrics.infrastructureInventoryTitle',
{
defaultMessage: 'Infrastructure Inventory',
}
),
Bluefinger marked this conversation as resolved.
Show resolved Hide resolved
app: 'metrics',
path: '/inventory',
},
...(this.config.featureFlags.metricsExplorerEnabled
? [{ label: 'Metrics Explorer', app: 'metrics', path: '/explorer' }]
? [
{
label: i18n.translate('xpack.infra.metrics.metricsExplorerTitle', {
defaultMessage: 'Metrics Explorer',
}),
app: 'metrics',
path: '/explorer',
},
]
: []),
...(isInfrastructureHostsViewEnabled
? [
{
label: 'Hosts',
label: i18n.translate('xpack.infra.metrics.hostsTitle', {
defaultMessage: 'Hosts',
}),
app: 'metrics',
path: '/hosts',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ export const metricsTitle = i18n.translate('xpack.infra.header.infrastructureTit
defaultMessage: 'Infrastructure',
});

export const inventoryTitle = i18n.translate('xpack.infra.metrics.inventoryPageTitle', {
defaultMessage: 'Inventory',
export const inventoryTitle = i18n.translate('xpack.infra.metrics.infrastructureInventoryTitle', {
defaultMessage: 'Infrastructure Inventory',
});

export const metricsExplorerTitle = i18n.translate('xpack.infra.metrics.metricsExplorerTitle', {
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -23567,7 +23567,6 @@
"xpack.infra.metrics.invalidNodeErrorTitle": "Il semblerait que {nodeName} ne collecte aucune donnée d'indicateurs",
"xpack.infra.metrics.inventory.alertFlyout.alertDescription": "Alerte lorsque l'inventaire dépasse un seuil défini.",
"xpack.infra.metrics.inventory.alertName": "Inventaire",
"xpack.infra.metrics.inventoryPageTitle": "Inventaire",
"xpack.infra.metrics.loadingNodeDataText": "Chargement des données",
"xpack.infra.metrics.metricsExplorerTitle": "Metrics Explorer",
"xpack.infra.metrics.missingTSVBModelError": "Le modèle TSVB pour {metricId} n'existe pas pour {nodeType}",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -23555,7 +23555,6 @@
"xpack.infra.metrics.invalidNodeErrorTitle": "{nodeName} がメトリックデータを収集していないようです",
"xpack.infra.metrics.inventory.alertFlyout.alertDescription": "インベントリが定義されたしきい値を超えたときにアラートを発行します。",
"xpack.infra.metrics.inventory.alertName": "インベントリ",
"xpack.infra.metrics.inventoryPageTitle": "インベントリ",
"xpack.infra.metrics.loadingNodeDataText": "データを読み込み中",
"xpack.infra.metrics.metricsExplorerTitle": "メトリックエクスプローラー",
"xpack.infra.metrics.missingTSVBModelError": "{nodeType}では{metricId}の TSVB モデルが存在しません",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -23585,7 +23585,6 @@
"xpack.infra.metrics.invalidNodeErrorTitle": "似乎 {nodeName} 未在收集任何指标数据",
"xpack.infra.metrics.inventory.alertFlyout.alertDescription": "当库存超过定义的阈值时告警。",
"xpack.infra.metrics.inventory.alertName": "库存",
"xpack.infra.metrics.inventoryPageTitle": "库存",
"xpack.infra.metrics.loadingNodeDataText": "正在加载数据",
"xpack.infra.metrics.metricsExplorerTitle": "指标浏览器",
"xpack.infra.metrics.missingTSVBModelError": "{nodeType} 的 {metricId} TSVB 模型不存在",
Expand Down
10 changes: 6 additions & 4 deletions x-pack/test/functional/apps/infra/home_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await pageObjects.header.waitUntilLoadingHasFinished();

const documentTitle = await browser.getTitle();
expect(documentTitle).to.contain('Inventory - Infrastructure - Observability - Elastic');
expect(documentTitle).to.contain(
'Infrastructure Inventory - Infrastructure - Observability - Elastic'
);
});

it('renders the inventory survey link', async () => {
Expand Down Expand Up @@ -457,7 +459,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await retry.tryForTime(5000, async () => {
const documentTitle = await browser.getTitle();
expect(documentTitle).to.contain(
'host-5 - Inventory - Infrastructure - Observability - Elastic'
'host-5 - Infrastructure Inventory - Infrastructure - Observability - Elastic'
);
});

Expand All @@ -474,7 +476,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await retry.tryForTime(5000, async () => {
const documentTitle = await browser.getTitle();
expect(documentTitle).to.contain(
'pod-0 - Inventory - Infrastructure - Observability - Elastic'
'pod-0 - Infrastructure Inventory - Infrastructure - Observability - Elastic'
);
});

Expand All @@ -492,7 +494,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await retry.tryForTime(5000, async () => {
const documentTitle = await browser.getTitle();
expect(documentTitle).to.contain(
'container-id-4 - Inventory - Infrastructure - Observability - Elastic'
'container-id-4 - Infrastructure Inventory - Infrastructure - Observability - Elastic'
);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await pageObjects.header.waitUntilLoadingHasFinished();

const documentTitle = await browser.getTitle();
expect(documentTitle).to.contain('Inventory - Infrastructure - Observability - Elastic');
expect(documentTitle).to.contain(
'Infrastructure Inventory - Infrastructure - Observability - Elastic'
);
});

it('renders an empty data prompt for dates with no data', async () => {
Expand Down Expand Up @@ -85,7 +87,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await retry.try(async () => {
const documentTitle = await browser.getTitle();
expect(documentTitle).to.contain(
'demo-stack-redis-01 - Inventory - Infrastructure - Observability - Elastic'
'demo-stack-redis-01 - Infrastructure Inventory - Infrastructure - Observability - Elastic'
);
});

Expand All @@ -101,7 +103,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await retry.try(async () => {
const documentTitle = await browser.getTitle();
expect(documentTitle).to.contain(
'pod-0 - Inventory - Infrastructure - Observability - Elastic'
'pod-0 - Infrastructure Inventory - Infrastructure - Observability - Elastic'
);
});

Expand Down