Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data plugin] Remove fieldFormats reexport #193238

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Sep 18, 2024

Summary

Removing data plugin's deprecated reexport of the field formats plugin.

Resume after #167437 is compete

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 18, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 18, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #44 / dashboard app - group 4 dashboard empty state adds a new data view when no data views
  • [job] [logs] FTR Configs #44 / dashboard app - group 4 dashboard empty state adds a new data view when no data views
  • [job] [logs] Jest Tests #15 / Export CSV action Should download if the API is compatible
  • [job] [logs] Jest Tests #15 / Export CSV action Should download if the API is compatible

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2594 2591 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 481.2KB 481.2KB -7.0B
dataVisualizer 725.1KB 725.1KB -53.0B
total -60.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 419.1KB 419.1KB +3.0B
Unknown metric groups

API count

id before after diff
data 3209 3206 -3

References to deprecated APIs

id before after diff
dashboard 40 38 -2
dataVisualizer 11 4 -7
expressionPartitionVis 8 0 -8
stackAlerts 24 23 -1
total -18

Unreferenced deprecated APIs

id before after diff
data 6 4 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime changed the title remove fieldFormats refs [data plugin] Remove fieldFormats reexport Sep 20, 2024
@mattkime mattkime self-assigned this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants