[tslint] Fix violations in kbn-pm #19335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 22, 2018 15:40
💚 Build Succeeded |
azasypkin
reviewed
May 23, 2018
packages/kbn-pm/src/cli.ts
Outdated
| @@ -11,6 +11,7 @@ function help() { | |||
| .map(commandName => commands[commandName]) | |||
| .map(command => `${command.name} - ${command.description}`); | |||
|
|
|||
| /* tslint:disable-next-line no-console */ | |||
| console.log(dedent` | |||
There was a problem hiding this comment.
question: can't we just create log.ts that exposes function with with console.log signature and add this annotation only there or just keep tslint.yaml with no-console: false? Just don't want to embrace these /* tslint: something */ all over the place, I'd rather have this somewhere in a single place.
There was a problem hiding this comment.
Yeah, I hope most people are averse to the tslint:disable directives and will avoid console.log() usage because of it, but I agree that having a suitable replacement is better than spreading the directives all over kbn-pm
azasypkin
approved these changes
May 23, 2018
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 23, 2018
* [tslint/kbn-pm] apply autofixes * [tslint/kbn-pm] whitelist all console.log calls for now * [tslint/kbn-pm] sort object keys alphabetically * [tslint/kbn-pm] use comments to "fill" empty blocks * [tslint/kbn-pm] use I-prefix for interface names * [tslint/kbn-pm] use arrow-functions where possible * [tslint/kbn-pm] use lowerCamelCase for variable names * [tslint/kbn-pm] prevent shadowed variable names * [tslint/kbn-pm] avoid variable name and type clashes * [tslint/kbn-pm] replace console.log statements with bare-bones logger
spalger
pushed a commit
that referenced
this pull request
May 23, 2018
|
6.4/6.x: 09ba816 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19105 included overrides for several tslint rules that the existing TypeScript in kbn-pm violated, in order to keep the size of that PR smaller.
This PR removes those overrides, autofixes the violations where possible, and then manually fixes the remaining violations.
I suggest reviewing this PR commit-by-commit rather than all at once.