-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Notes] - add note block to alert defaitls flyout header #193373
[Security Solution][Notes] - add note block to alert defaitls flyout header #193373
Conversation
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
9bd981d
to
3a747e0
Compare
3a747e0
to
9ace735
Compare
d9ef96d
to
abec400
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok the decision was to go with the smaller |
899da73
to
a063f0d
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
…header (elastic#193373) (cherry picked from commit 258adf5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…lyout header (#193373) (#193502) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] - add note block to alert defaitls flyout header (#193373)](#193373) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-09-20T00:39:28Z","message":"[Security Solution][Notes] - add note block to alert defaitls flyout header (#193373)","sha":"258adf533561b11d0cc0dae8c2fc2a1acc0d8e02","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:prev-minor","v8.16.0"],"title":"[Security Solution][Notes] - add note block to alert defaitls flyout header","number":193373,"url":"https://github.com/elastic/kibana/pull/193373","mergeCommit":{"message":"[Security Solution][Notes] - add note block to alert defaitls flyout header (#193373)","sha":"258adf533561b11d0cc0dae8c2fc2a1acc0d8e02"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193373","number":193373,"mergeCommit":{"message":"[Security Solution][Notes] - add note block to alert defaitls flyout header (#193373)","sha":"258adf533561b11d0cc0dae8c2fc2a1acc0d8e02"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
Summary
This PR adds a new section to the alert details flyout header to show how many notes have been added to the event or alert.
Note: This UI change only applies to the alert flyout. For event flyout, as we currently don't have this block section, we need to wait for UIUX to come up with a solution to show this note count
Here are the 2 states of this new section:
The UI updates automatically whenever a new note is added.
Screen.Recording.2024-09-18.at.6.28.04.PM.mov
Also the flyout renders the values on 1 or 2 rows, depending of the width of the flyout itself
Screen.Recording.2024-09-18.at.6.27.08.PM.mov
The PR also introduce a small UI change in the way we're showing the Status, Risk score, Assignees and the new Notes section. Instead of being a single block with vertical divider between the values, we're now show individual blocks.
#193342
TODO
Checklist