Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alert details page] Update alertDetailsUrl context variable URL #193674

Merged
merged 11 commits into from
Sep 24, 2024

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Sep 23, 2024

Closes #180889

Summary

Update the alertDetailsUrl context variable for the following rules:

  • Inventory rule
  • Metric threshold rule
  • Error count threshold rule
  • Failed transaction rate threshold rule
  • APM Anomaly rule
  • Synthetics TLS rule
  • Synthetics monitor status rule

@maryam-saeidi maryam-saeidi added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Sep 23, 2024
@maryam-saeidi maryam-saeidi self-assigned this Sep 23, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi maryam-saeidi marked this pull request as ready for review September 23, 2024 17:47
@maryam-saeidi maryam-saeidi requested review from a team as code owners September 23, 2024 17:47
@maryam-saeidi maryam-saeidi added the Team:obs-ux-management Observability Management User Experience Team label Sep 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Sep 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 24, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 25a96b3
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193674-25a96b34a6d5

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryam-saeidi maryam-saeidi merged commit 09082f2 into elastic:main Sep 24, 2024
27 checks passed
@maryam-saeidi maryam-saeidi deleted the 180889-alert-details-url branch September 24, 2024 20:02
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 24, 2024
…stic#193674)

Closes elastic#180889

## Summary

Update the alertDetailsUrl context variable for the following rules:

- Inventory rule
- Metric threshold rule
- Error count threshold rule
- Failed transaction rate threshold rule
- APM Anomaly rule
- Synthetics TLS rule
- Synthetics monitor status rule

(cherry picked from commit 09082f2)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 24, 2024
#193674) (#193920)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Alert details page] Update alertDetailsUrl context variable URL
(#193674)](#193674)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2024-09-24T20:02:14Z","message":"[Alert
details page] Update alertDetailsUrl context variable URL
(#193674)\n\nCloses #180889\r\n\r\n## Summary\r\n\r\nUpdate the
alertDetailsUrl context variable for the following rules:\r\n\r\n-
Inventory rule\r\n- Metric threshold rule\r\n- Error count threshold
rule\r\n- Failed transaction rate threshold rule\r\n- APM Anomaly
rule\r\n- Synthetics TLS rule\r\n- Synthetics monitor status
rule","sha":"09082f2d3e751776c8546e31cdad95db11cab8d5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","apm:review"],"title":"[Alert
details page] Update alertDetailsUrl context variable
URL","number":193674,"url":"#193674
details page] Update alertDetailsUrl context variable URL
(#193674)\n\nCloses #180889\r\n\r\n## Summary\r\n\r\nUpdate the
alertDetailsUrl context variable for the following rules:\r\n\r\n-
Inventory rule\r\n- Metric threshold rule\r\n- Error count threshold
rule\r\n- Failed transaction rate threshold rule\r\n- APM Anomaly
rule\r\n- Synthetics TLS rule\r\n- Synthetics monitor status
rule","sha":"09082f2d3e751776c8546e31cdad95db11cab8d5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"#193674
details page] Update alertDetailsUrl context variable URL
(#193674)\n\nCloses #180889\r\n\r\n## Summary\r\n\r\nUpdate the
alertDetailsUrl context variable for the following rules:\r\n\r\n-
Inventory rule\r\n- Metric threshold rule\r\n- Error count threshold
rule\r\n- Failed transaction rate threshold rule\r\n- APM Anomaly
rule\r\n- Synthetics TLS rule\r\n- Synthetics monitor status
rule","sha":"09082f2d3e751776c8546e31cdad95db11cab8d5"}}]}] BACKPORT-->

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Observability] [Alert] Update alertDetailsUrl to have link to alert detail pages
10 participants