Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detection Engine] fixes empty item_id in exception item update request schema #194175

Merged
merged 3 commits into from
Sep 30, 2024
Merged

[Security Solution][Detection Engine] fixes empty item_id in exception item update request schema #194175

merged 3 commits into from
Sep 30, 2024
+2 −1

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Sep 26, 2024 •
edited
Loading

Summary

  • fixes schema for updateExceptionListItemSchema , that led to error in 8.15

8.15 is fixed in #194172, in separate PR, since 8.16+ error in not reproducible.
But schema still is not correct. So this PR just fixes schema

@vitaliidm vitaliidm self-assigned this Sep 26, 2024
@vitaliidm vitaliidm added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area v8.16.0 backport:skip This commit does not require backporting labels Sep 26, 2024
@vitaliidm vitaliidm marked this pull request as ready for review September 27, 2024 09:37
@vitaliidm vitaliidm requested a review from a team as a code owner September 27, 2024 09:37
@vitaliidm vitaliidm requested a review from rylnd September 27, 2024 09:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@vitaliidm vitaliidm requested review from dhurley14 and removed request for rylnd September 27, 2024 09:38
@vitaliidm vitaliidm enabled auto-merge (squash) September 30, 2024 10:47
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.5MB 20.5MB -86.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm merged commit 49661a3 into elastic:main Sep 30, 2024
43 checks passed
@kibanamachine kibanamachine mentioned this pull request Sep 30, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley14 dhurley14 dhurley14 approved these changes

Assignees

@vitaliidm vitaliidm

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vitaliidm @elasticmachine @kibana-ci @dhurley14 @kibanamachine