Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dashboard snapshot tests #19420

Merged
merged 6 commits into from
May 29, 2018
Merged

Update dashboard snapshot tests #19420

merged 6 commits into from
May 29, 2018

Conversation

stacey-gammon
Copy link
Contributor

@stacey-gammon stacey-gammon commented May 24, 2018 •
edited
Loading

@stacey-gammon stacey-gammon added test Feature:Dashboard Dashboard related features :Sharing labels May 24, 2018
@stacey-gammon stacey-gammon force-pushed the 2018-05-snapshot-tests branch from b29dc8c to b06ce33 Compare May 24, 2018 20:02
@stacey-gammon stacey-gammon force-pushed the 2018-05-snapshot-tests branch from 1374667 to 82bc73f Compare May 25, 2018 00:13
@elastic elastic deleted a comment from elasticmachine May 25, 2018
@elastic elastic deleted a comment from elasticmachine May 25, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Contributor Author

Looks like flaky failure:

13:01:35 yarn run v1.6.0
13:01:35 $ gulp build
13:01:40 [13:01:40] Using gulpfile ~/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/x-pack/gulpfile.js
13:01:40 [13:01:40] Starting 'clean-test'...
13:01:40 [13:01:40] Starting 'report'...
13:01:40 [13:01:40] Starting 'prepare'...
13:01:40 [13:01:40] Finished 'clean-test' after 66 ms
13:01:40 [13:01:40] Starting 'clean'...
13:01:40 [13:01:40] Finished 'clean' after 22 ms
13:01:41 [13:01:41] Package Name x-pack
13:01:41 [13:01:41] Version 7.0.0-alpha1-SNAPSHOT
13:01:41 [13:01:41] Build Number 17450
13:01:41 [13:01:41] Build SHA 9f57520dda8640798f5bc72495f5c255f8182235
13:01:41 [13:01:41] Finished 'report' after 749 ms
13:03:47 [13:03:47] 'prepare' errored after 2.12 min
13:03:47 [13:03:47] Error: connect ETIMEDOUT 54.231.82.68:443
13:03:47     at Object._errnoException (util.js:1022:11)
13:03:47     at _exceptionWithHostPort (util.js:1044:20)
13:03:47     at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1198:14)
13:03:47 error Command failed with exit code 1.
13:03:47 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
13:03:47    │ERROR  failure
13:03:48    │ERROR  Error: Command failed: yarn run build
13:03:48    │           at makeError (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/packages/kbn-pm/dist/index.js:39003:9)
13:03:48    │           at Promise.all.then.arr (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/packages/kbn-pm/dist/index.js:39108:16)
13:03:48    │           at <anonymous>
13:03:48    │           at process._tickCallback (internal/process/next_tick.js:188:7)

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon stacey-gammon requested a review from nreese May 29, 2018 15:47
nreese
nreese approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stacey-gammon stacey-gammon merged commit 803d0a6 into elastic:master May 29, 2018
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request May 29, 2018
@stacey-gammon
Update dashboard snapshot tests (elastic#19420)
0bfb604 
* update snapshot tests

* Update time ranges

* Add sleeps, adjust time, update snapshots

* Skip TSVB until the issue with vertical line placement and x-axis timestamps is fixed

* fix expectations of time range with saved search creation

* remove debug line
@stacey-gammon stacey-gammon mentioned this pull request May 29, 2018
Closed
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request May 30, 2018
@stacey-gammon
Update dashboard snapshot tests (elastic#19420)
c945baf 
* update snapshot tests

* Update time ranges

* Add sleeps, adjust time, update snapshots

* Skip TSVB until the issue with vertical line placement and x-axis timestamps is fixed

* fix expectations of time range with saved search creation

* remove debug line
@stacey-gammon stacey-gammon mentioned this pull request May 30, 2018
Merged
stacey-gammon added a commit that referenced this pull request May 30, 2018
@stacey-gammon
Update dashboard snapshot tests (#19420) (#19562)
40e24f0 
* update snapshot tests

* Update time ranges

* Add sleeps, adjust time, update snapshots

* Skip TSVB until the issue with vertical line placement and x-axis timestamps is fixed

* fix expectations of time range with saved search creation

* remove debug line
@stacey-gammon stacey-gammon deleted the 2018-05-snapshot-tests branch June 11, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stacey-gammon @elasticmachine @nreese