[8.x] Fix AggConfig backslash escaping (#193932) #194324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Fixes `AggConfig` handling to properly escape backslash as well as the single quote it already escapes. (I believe this has been around ever since elastic#2486.) (cherry picked from commit 9916dd0)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Page load bundle
To update your PR or re-run it, just comment with: cc @lukasolson |
lukasolson
added a commit
that referenced
this pull request
Oct 22, 2024
# Backport This will backport the following commits from `main` to `7.17`: - [Fix AggConfig backslash escaping (#193932)](#193932) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lukas Olson","email":"lukas@elastic.co"},"sourceCommit":{"committedDate":"2024-09-27T15:56:48Z","message":"Fix AggConfig backslash escaping (#193932)\n\n## Summary\r\n\r\nFixes `AggConfig` handling to properly escape backslash as well as the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been around ever since\r\nhttps://github.com//pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Aggregations","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","backport:prev-major","v8.16.0","v8.15.4"],"number":193932,"url":"https://github.com/elastic/kibana/pull/193932","mergeCommit":{"message":"Fix AggConfig backslash escaping (#193932)\n\n## Summary\r\n\r\nFixes `AggConfig` handling to properly escape backslash as well as the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been around ever since\r\nhttps://github.com//pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193932","number":193932,"mergeCommit":{"message":"Fix AggConfig backslash escaping (#193932)\n\n## Summary\r\n\r\nFixes `AggConfig` handling to properly escape backslash as well as the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been around ever since\r\nhttps://github.com//pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/194324","number":194324,"state":"MERGED","mergeCommit":{"sha":"6040c6ed836f3a0a62545198119af20b2502301e","message":"[8.x] Fix AggConfig backslash escaping (#193932) (#194324)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [Fix AggConfig backslash escaping\n(#193932)](https://github.com/elastic/kibana/pull/193932)\n\n<!--- Backport version: 9.4.3 -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation