Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Update connectors doc links & find/replace terms #194423

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Sep 30, 2024

Summary

  • Update doc links now that connectors live in the Elasticsearch guide
  • Update terms:
    • Native connectors -> Elastic managed connectors
    • Connector clients -> Self-managed connectors

Example screenshot

Screenshot 2024-09-30 at 13 41 54

(adding a release note for visibility)

Release note

We renamed native connectors and connector clients to Elastic managed connectors and self-managed connectors in the Kibana UI. Please note also that the connectors documentation now lives in the {ref}/es-connectors.html[Elasticsearch docs].

@leemthompo leemthompo requested review from a team as code owners September 30, 2024 11:53
@leemthompo leemthompo self-assigned this Sep 30, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@leemthompo
Copy link
Contributor Author

cc @danajuratoni @serenachou @JoseLuisGJ

@leemthompo
Copy link
Contributor Author

Docs build error to be fixed with elastic/elasticsearch#113800

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / CaseDetailsLink renders
  • [job] [logs] FTR Configs #63 / discover/esql discover esql view switch modal should not show switch modal when switching to a data view while a saved search is open

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 91.1KB 91.2KB +148.0B
enterpriseSearch 2.6MB 2.6MB +612.0B
lists 143.6KB 143.7KB +148.0B
serverlessSearch 327.2KB 327.2KB +12.0B
total +920.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 455.7KB 455.9KB +148.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @leemthompo

@leemthompo leemthompo merged commit ddab54f into elastic:main Oct 1, 2024
24 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.9, 8.x

https://github.com/elastic/kibana/actions/runs/11121221370

@leemthompo leemthompo removed the v8.9.0 label Oct 1, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 1, 2024
…4423)

## Summary

- Update doc links now that connectors live in the Elasticsearch guide
- Update terms:
  - Native connectors -> _Elastic managed connectors_
  - Connector clients -> _Self-managed connectors_

(cherry picked from commit ddab54f)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.9 Backport failed because of merge conflicts
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 194423

Questions ?

Please refer to the Backport tool documentation

@leemthompo leemthompo deleted the connectors-docs-links branch October 1, 2024 08:27
kibanamachine added a commit that referenced this pull request Oct 1, 2024
…194423) (#194522)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search] Update connectors doc links & find/replace terms
(#194423)](#194423)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Liam
Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-01T08:07:40Z","message":"[Search]
Update connectors doc links & find/replace terms (#194423)\n\n## Summary
\r\n\r\n- Update doc links now that connectors live in the Elasticsearch
guide\r\n- Update terms:\r\n - Native connectors -> _Elastic managed
connectors_\r\n - Connector clients -> _Self-managed
connectors_","sha":"ddab54f0a830106b47ca23d57caeeadb6a8898e7","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Team:Search","Team:EnterpriseSearch","v8.9.0","v8.16.0","backport:version"],"title":"[Search]
Update connectors doc links & find/replace
terms","number":194423,"url":"https://github.com/elastic/kibana/pull/194423","mergeCommit":{"message":"[Search]
Update connectors doc links & find/replace terms (#194423)\n\n## Summary
\r\n\r\n- Update doc links now that connectors live in the Elasticsearch
guide\r\n- Update terms:\r\n - Native connectors -> _Elastic managed
connectors_\r\n - Connector clients -> _Self-managed
connectors_","sha":"ddab54f0a830106b47ca23d57caeeadb6a8898e7"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194423","number":194423,"mergeCommit":{"message":"[Search]
Update connectors doc links & find/replace terms (#194423)\n\n## Summary
\r\n\r\n- Update doc links now that connectors live in the Elasticsearch
guide\r\n- Update terms:\r\n - Native connectors -> _Elastic managed
connectors_\r\n - Connector clients -> _Self-managed
connectors_","sha":"ddab54f0a830106b47ca23d57caeeadb6a8898e7"}},{"branch":"8.9","label":"v8.9.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
leemthompo added a commit that referenced this pull request Oct 8, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants