Extract AI assistant to package #194552
Merged
Extract AI assistant to package #194552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
afharo
reviewed
Oct 1, 2024
x-pack/packages/kbn-ai-assistant/src/buttons/ask_assistant_button.tsx
Outdated
Show resolved
Hide resolved
joemcelroy
reviewed
Oct 2, 2024
joemcelroy
approved these changes
Oct 2, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
dgieselaar
reviewed
Oct 7, 2024
x-pack/packages/kbn-ai-assistant/src/context/ai_assistant_app_service_provider.tsx
Outdated
Show resolved
Hide resolved
x-pack/packages/kbn-ai-assistant/src/hooks/use_simulated_function_calling.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/observability_ai_assistant/public/hooks/use_once.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/observability_ai_assistant_app/public/application.tsx
Show resolved
Hide resolved
.../observability_ai_assistant_app/public/routes/conversations/conversation_view_with_props.tsx
Show resolved
Hide resolved
dgieselaar
approved these changes
Oct 9, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11274755711 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sphilipse
added a commit
to sphilipse/kibana
that referenced
this pull request
Oct 12, 2024
## Summary This extracts the Observability AI Assistant into a shared package so Search and Observability can both consume it. A few notes: This still relies on significantly tight coupling with the Obs AI assistant plugin, which we will want to slowly decouple over time. It means that currently to consume this in multiple places, you need to provide a number of plugins for useKibana. Hopefully we can get rid of that and replace them with props eventually and make the interface a little less plugin-dependent. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 8a3a059) # Conflicts: # .github/CODEOWNERS
sphilipse
added a commit
that referenced
this pull request
Oct 12, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Extract AI assistant to package (#194552)](#194552) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-10T13:11:49Z","message":"Extract AI assistant to package (#194552)\n\n## Summary\r\n\r\nThis extracts the Observability AI Assistant into a shared package so\r\nSearch and Observability can both consume it.\r\n\r\nA few notes:\r\n\r\nThis still relies on significantly tight coupling with the Obs AI\r\nassistant plugin, which we will want to slowly decouple over time. It\r\nmeans that currently to consume this in multiple places, you need to\r\nprovide a number of plugins for useKibana. Hopefully we can get rid of\r\nthat and replace them with props eventually and make the interface a\r\nlittle less plugin-dependent.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"8a3a05927bdbe264c491b4034ff5d81674f3db73","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","Team:Obs AI Assistant","ci:project-deploy-observability","v8.16.0","backport:version"],"number":194552,"url":"https://github.com/elastic/kibana/pull/194552","mergeCommit":{"message":"Extract AI assistant to package (#194552)\n\n## Summary\r\n\r\nThis extracts the Observability AI Assistant into a shared package so\r\nSearch and Observability can both consume it.\r\n\r\nA few notes:\r\n\r\nThis still relies on significantly tight coupling with the Obs AI\r\nassistant plugin, which we will want to slowly decouple over time. It\r\nmeans that currently to consume this in multiple places, you need to\r\nprovide a number of plugins for useKibana. Hopefully we can get rid of\r\nthat and replace them with props eventually and make the interface a\r\nlittle less plugin-dependent.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"8a3a05927bdbe264c491b4034ff5d81674f3db73"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194552","number":194552,"mergeCommit":{"message":"Extract AI assistant to package (#194552)\n\n## Summary\r\n\r\nThis extracts the Observability AI Assistant into a shared package so\r\nSearch and Observability can both consume it.\r\n\r\nA few notes:\r\n\r\nThis still relies on significantly tight coupling with the Obs AI\r\nassistant plugin, which we will want to slowly decouple over time. It\r\nmeans that currently to consume this in multiple places, you need to\r\nprovide a number of plugins for useKibana. Hopefully we can get rid of\r\nthat and replace them with props eventually and make the interface a\r\nlittle less plugin-dependent.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"8a3a05927bdbe264c491b4034ff5d81674f3db73"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This extracts the Observability AI Assistant into a shared package so Search and Observability can both consume it.
A few notes:
This still relies on significantly tight coupling with the Obs AI assistant plugin, which we will want to slowly decouple over time. It means that currently to consume this in multiple places, you need to provide a number of plugins for useKibana. Hopefully we can get rid of that and replace them with props eventually and make the interface a little less plugin-dependent.