Commits on Oct 9, 2024

1. [Security Assistant] V2 Knowledge Base Settings feedback and fixes (e… …

   …lastic#194354)
   
   ## Summary
   
   This PR is a follow up to elastic#192665 and addresses a bunch of feedback and
   fixes including:
   
   - [X] Adds support for updating/editing entries
   - [X] Fixes initial loading experience of the KB Settings Setup/Table
   - [X] Fixes two bugs where `semantic_text` and `text` must be declared
   for `IndexEntries` to work
   - [X] Add new Settings Context Menu items for KB and Alerts
    - [X] Add support for `required` entries in initial prompt
   * See [this
   trace](https://smith.langchain.com/public/84a17a31-8ce8-4bd9-911e-38a854484dd8/r)
   for included knowledge. Note that the KnowledgeBaseRetrievalTool was not
   selected.
   * Note: All prompts were updated to include the `{knowledge_history}`
   placeholder, and _not behind the feature flag_, as this will just be the
   empty case until the feature flag is enabled.
   
   TODO (in this or follow-up PR):
    - [ ] Add suggestions to `index` and `fields` inputs
    - [ ] Adds URL deeplinking to securityAssistantManagement
   - [ ] Fix bug where updating entry does not re-create embeddings (see
   [comment](elastic#194354 (comment)))
    - [ ] Fix loading indicators when adding/editing entries
    - [ ] API integration tests for update API (@e40pud)
   
   ### Checklist
   
   Delete any items that are not applicable to this PR.
   
   - [X] Any text added follows [EUI's writing
   guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
   sentence case text and includes [i18n
   support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
   - [ ]
   [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
   was added for features that require explanation or tutorials
   * Docs being tracked in
   elastic/security-docs#5337 for when feature
   flag is enabled
   - [ ] [Unit or functional
   tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
   were updated or added to match the most common scenarios
   
   ---------
   
   Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
   Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
   (cherry picked from commit 7df3672)

   

   spong committed Oct 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 65d1a9d
   • Browse repository at this point

   Copy the full SHA

   65d1a9d View commit details

   Browse the repository at this point in the history