Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump ironbank version to 9.4 #195864

Merged
merged 2 commits into from
Oct 11, 2024
Merged

deps: Bump ironbank version to 9.4 #195864

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad6c3e3
chore: deps(ironbank): Bump ubi version to 9.4
github-actions[bot] Oct 11, 2024
bc6cc85
Merge branch 'main' into updatecli_main_ironbank_template
v1v Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/dev/build/tasks/os_packages/docker_generator/templates/ironbank/hardening_manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,17 @@
---
apiVersion: v1

# The repository name in registry1, excluding /ironbank/
name: 'elastic/kibana/kibana'

# List of tags to push for the repository in registry1
# The most specific version should be the first tag and will be shown
# on ironbank.dsop.io
tags:
- '{{version}}'
- 'latest'

# Build args passed to Dockerfile ARGs
args:
BASE_IMAGE: 'redhat/ubi/ubi9'
BASE_TAG: '9.4'

BASE_TAG: "9.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems others use double quotes:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this formatting is based on the yaml engine: https://www.updatecli.io/docs/plugins/resource/yaml/

We don't have consistent yaml formatting between Kibana devs (related #191562). This is fine for now, but if we have issues of the formatting going back and forth, we'll need to find a solution.

# Docker image labels
labels:
org.opencontainers.image.title: 'kibana'
Expand All @@ -27,7 +23,6 @@ labels:
# mil.dso.ironbank.image.keywords: ""
# mil.dso.ironbank.image.type: "commercial"
mil.dso.ironbank.product.name: 'Kibana'

# List of resources to make available to the offline build context
resources:
- filename: kibana-{{version}}-linux-x86_64.tar.gz
Expand All @@ -45,7 +40,6 @@ resources:
validation:
type: sha512
value: 0ce56bde1853fed3e53282505bac65707385275a27816c29712ab04c187aa249797c82c58759b2b36c210d4e2683eda92359d739a8045cb8385c2c34d37cc9e1

# List of project maintainers
maintainers:
- email: 'jon@elastic.co'
Expand Down