[Security Solution] Deletes Old Timeline Code #196243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
added a commit
that referenced
this pull request
Oct 24, 2024
…#195959) ## Summary Handles elastic/security-team#9645 Follow Up PR for removal of Old timeline Code : #196243 - This PR removes `unifiedComponentsInTimelineDisabled` flag. What this means that that unified components in Timeline are now enabled by default. - Consequently, the old timeline table code becomes obsolete and is also removed. ( #196243) ## Changes 1. Converted all cypress and jest tests that were testing old Timeline table to test new unified components in Timeline. If the test for new timeline already existed, old tests are also removed.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
…elastic#195959) ## Summary Handles elastic/security-team#9645 Follow Up PR for removal of Old timeline Code : elastic#196243 - This PR removes `unifiedComponentsInTimelineDisabled` flag. What this means that that unified components in Timeline are now enabled by default. - Consequently, the old timeline table code becomes obsolete and is also removed. ( elastic#196243) ## Changes 1. Converted all cypress and jest tests that were testing old Timeline table to test new unified components in Timeline. If the test for new timeline already existed, old tests are also removed. (cherry picked from commit c41178d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
…elastic#195959) ## Summary Handles elastic/security-team#9645 Follow Up PR for removal of Old timeline Code : elastic#196243 - This PR removes `unifiedComponentsInTimelineDisabled` flag. What this means that that unified components in Timeline are now enabled by default. - Consequently, the old timeline table code becomes obsolete and is also removed. ( elastic#196243) ## Changes 1. Converted all cypress and jest tests that were testing old Timeline table to test new unified components in Timeline. If the test for new timeline already existed, old tests are also removed. (cherry picked from commit c41178d)
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
…abled` flag (#195959) (#197693) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Remove `unifiedComponentsInTimelineDisabled` flag (#195959)](#195959) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T16:41:19Z","message":"[Security Solution] Remove `unifiedComponentsInTimelineDisabled` flag (#195959)\n\n## Summary\r\n\r\nHandles https://github.com/elastic/security-team/issues/9645\r\n\r\nFollow Up PR for removal of Old timeline Code :\r\nhttps://github.com//pull/196243\r\n\r\n- This PR removes `unifiedComponentsInTimelineDisabled` flag. What this\r\nmeans that that unified components in Timeline are now enabled by\r\ndefault.\r\n\r\n- Consequently, the old timeline table code becomes obsolete and is also\r\nremoved. ( https://github.com/elastic/kibana/pull/196243)\r\n\r\n## Changes\r\n\r\n1. Converted all cypress and jest tests that were testing old Timeline\r\ntable to test new unified components in Timeline. If the test for new\r\ntimeline already existed, old tests are also removed.","sha":"c41178d2d6e952798548ccd7db691d5ceff62053","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution] Remove `unifiedComponentsInTimelineDisabled` flag","number":195959,"url":"https://github.com/elastic/kibana/pull/195959","mergeCommit":{"message":"[Security Solution] Remove `unifiedComponentsInTimelineDisabled` flag (#195959)\n\n## Summary\r\n\r\nHandles https://github.com/elastic/security-team/issues/9645\r\n\r\nFollow Up PR for removal of Old timeline Code :\r\nhttps://github.com//pull/196243\r\n\r\n- This PR removes `unifiedComponentsInTimelineDisabled` flag. What this\r\nmeans that that unified components in Timeline are now enabled by\r\ndefault.\r\n\r\n- Consequently, the old timeline table code becomes obsolete and is also\r\nremoved. ( https://github.com/elastic/kibana/pull/196243)\r\n\r\n## Changes\r\n\r\n1. Converted all cypress and jest tests that were testing old Timeline\r\ntable to test new unified components in Timeline. If the test for new\r\ntimeline already existed, old tests are also removed.","sha":"c41178d2d6e952798548ccd7db691d5ceff62053"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195959","number":195959,"mergeCommit":{"message":"[Security Solution] Remove `unifiedComponentsInTimelineDisabled` flag (#195959)\n\n## Summary\r\n\r\nHandles https://github.com/elastic/security-team/issues/9645\r\n\r\nFollow Up PR for removal of Old timeline Code :\r\nhttps://github.com//pull/196243\r\n\r\n- This PR removes `unifiedComponentsInTimelineDisabled` flag. What this\r\nmeans that that unified components in Timeline are now enabled by\r\ndefault.\r\n\r\n- Consequently, the old timeline table code becomes obsolete and is also\r\nremoved. ( https://github.com/elastic/kibana/pull/196243)\r\n\r\n## Changes\r\n\r\n1. Converted all cypress and jest tests that were testing old Timeline\r\ntable to test new unified components in Timeline. If the test for new\r\ntimeline already existed, old tests are also removed.","sha":"c41178d2d6e952798548ccd7db691d5ceff62053"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
…sabled` flag (#195959) (#197692) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution] Remove `unifiedComponentsInTimelineDisabled` flag (#195959)](#195959) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T16:41:19Z","message":"[Security Solution] Remove `unifiedComponentsInTimelineDisabled` flag (#195959)\n\n## Summary\r\n\r\nHandles https://github.com/elastic/security-team/issues/9645\r\n\r\nFollow Up PR for removal of Old timeline Code :\r\nhttps://github.com//pull/196243\r\n\r\n- This PR removes `unifiedComponentsInTimelineDisabled` flag. What this\r\nmeans that that unified components in Timeline are now enabled by\r\ndefault.\r\n\r\n- Consequently, the old timeline table code becomes obsolete and is also\r\nremoved. ( https://github.com/elastic/kibana/pull/196243)\r\n\r\n## Changes\r\n\r\n1. Converted all cypress and jest tests that were testing old Timeline\r\ntable to test new unified components in Timeline. If the test for new\r\ntimeline already existed, old tests are also removed.","sha":"c41178d2d6e952798548ccd7db691d5ceff62053","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution] Remove `unifiedComponentsInTimelineDisabled` flag","number":195959,"url":"https://github.com/elastic/kibana/pull/195959","mergeCommit":{"message":"[Security Solution] Remove `unifiedComponentsInTimelineDisabled` flag (#195959)\n\n## Summary\r\n\r\nHandles https://github.com/elastic/security-team/issues/9645\r\n\r\nFollow Up PR for removal of Old timeline Code :\r\nhttps://github.com//pull/196243\r\n\r\n- This PR removes `unifiedComponentsInTimelineDisabled` flag. What this\r\nmeans that that unified components in Timeline are now enabled by\r\ndefault.\r\n\r\n- Consequently, the old timeline table code becomes obsolete and is also\r\nremoved. ( https://github.com/elastic/kibana/pull/196243)\r\n\r\n## Changes\r\n\r\n1. Converted all cypress and jest tests that were testing old Timeline\r\ntable to test new unified components in Timeline. If the test for new\r\ntimeline already existed, old tests are also removed.","sha":"c41178d2d6e952798548ccd7db691d5ceff62053"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195959","number":195959,"mergeCommit":{"message":"[Security Solution] Remove `unifiedComponentsInTimelineDisabled` flag (#195959)\n\n## Summary\r\n\r\nHandles https://github.com/elastic/security-team/issues/9645\r\n\r\nFollow Up PR for removal of Old timeline Code :\r\nhttps://github.com//pull/196243\r\n\r\n- This PR removes `unifiedComponentsInTimelineDisabled` flag. What this\r\nmeans that that unified components in Timeline are now enabled by\r\ndefault.\r\n\r\n- Consequently, the old timeline table code becomes obsolete and is also\r\nremoved. ( https://github.com/elastic/kibana/pull/196243)\r\n\r\n## Changes\r\n\r\n1. Converted all cypress and jest tests that were testing old Timeline\r\ntable to test new unified components in Timeline. If the test for new\r\ntimeline already existed, old tests are also removed.","sha":"c41178d2d6e952798548ccd7db691d5ceff62053"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
1 task
logeekal
force-pushed
the
delete/old_timeline_code
branch
from
37e7723 to
4ab5f0b
Compare
logeekal
commented
Nov 6, 2024
| * 2.0. | ||
| */ | ||
|
|
||
| import type { TimelineNonEcsData } from '@kbn/timelines-plugin/common'; |
There was a problem hiding this comment.
This is a utility that was part of on of the deleted file but is required at other places as well so moved here.
logeekal
commented
Nov 6, 2024
| @@ -282,3 +282,14 @@ export const TIMELINE_FILTER_DROP_AREA = 'timeline-filter-drop-area'; | |||
|
|
|||
| export const getNonDropAreaFilters = (filters: Filter[] = []) => | |||
| filters.filter((f: Filter) => f.meta.controlledBy !== TIMELINE_FILTER_DROP_AREA); | |||
|
|
|||
| export const isFullScreen = ({ | |||
There was a problem hiding this comment.
This is a utility that was part of on of the deleted file but is required at other places as well so moved here.
There was a problem hiding this comment.
could maybe add a couple of unit tests for it, even though it's super simple?
There was a problem hiding this comment.
Done here : f8a4121
logeekal
added
backport
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
There was a problem hiding this comment.
what do you think about writing some basic unit tests for the 2 methods here?
There was a problem hiding this comment.
Good point. Should not have missed that. Will add those.
| @@ -282,3 +282,14 @@ export const TIMELINE_FILTER_DROP_AREA = 'timeline-filter-drop-area'; | |||
|
|
|||
| export const getNonDropAreaFilters = (filters: Filter[] = []) => | |||
| filters.filter((f: Filter) => f.meta.controlledBy !== TIMELINE_FILTER_DROP_AREA); | |||
|
|
|||
| export const isFullScreen = ({ | |||
There was a problem hiding this comment.
could maybe add a couple of unit tests for it, even though it's super simple?
PhilippeOberti
approved these changes
Nov 6, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11721344293 |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
## Summary Fixes elastic/security-team#9676 This is follow up of the PR : elastic#195959 where we had removed feature flag `unifiedComponentsInTimelineDisabled`. This PR completes unified components migration in Timeline. ## Changes Most changes in this PR are : 1. Deletion for the obsolete code. 2. Refactoring of needed utils ( only 3. have marked in comments below ) 3. Updating import path of above utils. (cherry picked from commit c9d167f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Deletes Old Timeline Code (#196243)](#196243) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-11-07T10:39:55Z","message":"[Security Solution] Deletes Old Timeline Code (#196243)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/security-team/issues/9676\r\n\r\nThis is follow up of the PR :\r\nhttps://github.com//pull/195959 where we had removed\r\nfeature flag `unifiedComponentsInTimelineDisabled`.\r\n\r\nThis PR completes unified components migration in Timeline. \r\n\r\n## Changes\r\n\r\nMost changes in this PR are : \r\n\r\n1. Deletion for the obsolete code.\r\n2. Refactoring of needed utils ( only 3. have marked in comments below )\r\n3. Updating import path of above utils.","sha":"c9d167f1ab584c315f820dc94ba2d51864d508f4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.17.0"],"title":"[Security Solution] Deletes Old Timeline Code","number":196243,"url":"https://github.com/elastic/kibana/pull/196243","mergeCommit":{"message":"[Security Solution] Deletes Old Timeline Code (#196243)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/security-team/issues/9676\r\n\r\nThis is follow up of the PR :\r\nhttps://github.com//pull/195959 where we had removed\r\nfeature flag `unifiedComponentsInTimelineDisabled`.\r\n\r\nThis PR completes unified components migration in Timeline. \r\n\r\n## Changes\r\n\r\nMost changes in this PR are : \r\n\r\n1. Deletion for the obsolete code.\r\n2. Refactoring of needed utils ( only 3. have marked in comments below )\r\n3. Updating import path of above utils.","sha":"c9d167f1ab584c315f820dc94ba2d51864d508f4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196243","number":196243,"mergeCommit":{"message":"[Security Solution] Deletes Old Timeline Code (#196243)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/security-team/issues/9676\r\n\r\nThis is follow up of the PR :\r\nhttps://github.com//pull/195959 where we had removed\r\nfeature flag `unifiedComponentsInTimelineDisabled`.\r\n\r\nThis PR completes unified components migration in Timeline. \r\n\r\n## Changes\r\n\r\nMost changes in this PR are : \r\n\r\n1. Deletion for the obsolete code.\r\n2. Refactoring of needed utils ( only 3. have marked in comments below )\r\n3. Updating import path of above utils.","sha":"c9d167f1ab584c315f820dc94ba2d51864d508f4"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
## Summary Fixes elastic/security-team#9676 This is follow up of the PR : elastic#195959 where we had removed feature flag `unifiedComponentsInTimelineDisabled`. This PR completes unified components migration in Timeline. ## Changes Most changes in this PR are : 1. Deletion for the obsolete code. 2. Refactoring of needed utils ( only 3. have marked in comments below ) 3. Updating import path of above utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/elastic/security-team/issues/9676
This is follow up of the PR : #195959 where we had removed feature flag
unifiedComponentsInTimelineDisabled.This PR completes unified components migration in Timeline.
Changes
Most changes in this PR are :