Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] show fullscreen mode when url has fullScreenMode param #196275

Merged
merged 7 commits into from
Oct 24, 2024
Merged

[Dashboard] show fullscreen mode when url has fullScreenMode param #196275

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0efa4eb
[Dashboard] show fullscreen mode when url has fullScreenMode param
lsq645599166 Oct 15, 2024
772e8a3
[Dashboard] save fullScreenMode state in type InitialComponentState
lsq645599166 Oct 18, 2024
4489813
Merge branch 'main' into fix/fullscreen_url_param
elasticmachine Oct 18, 2024
78fd591
Merge branch 'main' into fix/fullscreen_url_param
elasticmachine Oct 21, 2024
267aab2
[Dashboard] put fullScreenMode as a top level key in creationOptions
lsq645599166 Oct 21, 2024
3bd11ce
[Dashboard] fix type lint
lsq645599166 Oct 22, 2024
2d5faf3
Merge branch 'main' into fix/fullscreen_url_param
Heenawter Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/plugins/dashboard/common/dashboard_container/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export interface DashboardContainerInput extends EmbeddableInput {
timeRange?: TimeRange;
timeslice?: [number, number];
refreshInterval?: RefreshInterval;
fullScreenMode?: boolean;
Heenawter marked this conversation as resolved.
Show resolved Hide resolved

// dashboard meta info
title: string;
Expand Down
5 changes: 5 additions & 0 deletions src/plugins/dashboard/public/dashboard_container/embeddable/create/create_dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ export const initializeDashboard = async ({
query,
filters,
timeRestore,
fullScreenMode,
timeRange: savedTimeRange,
refreshInterval: savedRefreshInterval,
} = initialDashboardInput;
Expand Down Expand Up @@ -327,6 +328,10 @@ export const initializeDashboard = async ({
stopSyncingUnifiedSearchState();
stopSyncingQueryServiceStateWithUrl();
};

if (fullScreenMode != null) {
setTimeout(() => dashboardContainer.setFullScreenMode(fullScreenMode), 500);
}
});
}

Expand Down