Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings #196977

Conversation

paulinashakirova
Copy link
Contributor

@paulinashakirova paulinashakirova commented Oct 19, 2024

Summary

This PR fixes the #190562 where the created and updated timestamps for Dashboards do not respect the default timezone settings in advanced settings.

Currently, if the user changes the timezone in the advanced settings, the timestamps for the activity monitor flyout still display timestamps from the default browser timezone. This PR ensures that the timestamps display in the desired timezone.

Screenshot 2024-10-19 at 13 35 00

Screenshot 2024-10-19 at 13 36 02

@paulinashakirova paulinashakirova added release_note:fix v9.0.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.17.0 labels Oct 19, 2024
@paulinashakirova paulinashakirova self-assigned this Oct 19, 2024
@paulinashakirova paulinashakirova requested a review from a team as a code owner October 19, 2024 11:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant
Copy link
Contributor

Dosant commented Oct 21, 2024

Let's backport to prev-major (so it gets into 8.16)

@paulinashakirova paulinashakirova added backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 22, 2024
@paulinashakirova paulinashakirova marked this pull request as draft October 23, 2024 09:10
@paulinashakirova paulinashakirova marked this pull request as ready for review October 23, 2024 10:50
@paulinashakirova paulinashakirova marked this pull request as draft October 23, 2024 12:47
@paulinashakirova paulinashakirova force-pushed the dynamic-update-timestamp-based-on-timezone-in-advanced-settings branch from d69b37f to 65d0179 Compare October 23, 2024 14:21
@paulinashakirova paulinashakirova marked this pull request as ready for review October 23, 2024 15:11
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 642.2KB 642.3KB +66.0B
eventAnnotationListing 226.9KB 227.0KB +71.0B
filesManagement 120.6KB 120.7KB +70.0B
graph 413.2KB 413.3KB +71.0B
maps 3.0MB 3.0MB +79.0B
visualizations 315.5KB 315.6KB +74.0B
total +431.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 50.4KB 50.4KB +58.0B
eventAnnotationListing 10.9KB 11.0KB +58.0B
filesManagement 4.0KB 4.0KB +58.0B
graph 8.0KB 8.1KB +58.0B
maps 54.3KB 54.4KB +58.0B
visualizations 70.9KB 71.0KB +58.0B
total +348.0B

History

  • 💔 Build #244985 failed d69b37f395b99e6b1348e6f78163ca021a15219b
  • 💔 Build #244792 failed 7baad98dfe21272baf9036738f65079a945e7887

cc @paulinashakirova

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@Dosant
Copy link
Contributor

Dosant commented Oct 24, 2024

Let's backport to prev-major (so it gets into 8.16)

I think I confused myself. prev-major will get it into 8.x, 8.16, 8.15. But this feature will be released in 8.16, so we shouldn't backport it to 8.15.
as far as I understand, instead we should use backport:version and specific version. like so:

Screenshot 2024-10-24 at 11 29 07

🤦 sorry, I confused with another feature. this could be backported to 8.15

@paulinashakirova paulinashakirova added backport:version Backport to applied version labels and removed backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development v9.0.0 labels Oct 24, 2024
@paulinashakirova paulinashakirova added v8.16.0 backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development and removed v8.17.0 v8.16.0 backport:version Backport to applied version labels labels Oct 24, 2024
@paulinashakirova paulinashakirova merged commit 7fa1e18 into elastic:main Oct 24, 2024
36 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11500197301

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
…e Advanced Settings (elastic#196977)

## Summary

This PR fixes the
[elastic#190562](elastic#190562) where the
created and updated timestamps for Dashboards do not respect the default
timezone settings in advanced settings.

Currently, if the user changes the timezone in the advanced settings,
the timestamps for the activity monitor flyout still display timestamps
from the default browser timezone. This PR ensures that the timestamps
display in the desired timezone.

![Screenshot 2024-10-19 at 13 35
00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)

![Screenshot 2024-10-19 at 13 36
02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)

(cherry picked from commit 7fa1e18)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
…e Advanced Settings (elastic#196977)

## Summary

This PR fixes the
[elastic#190562](elastic#190562) where the
created and updated timestamps for Dashboards do not respect the default
timezone settings in advanced settings.

Currently, if the user changes the timezone in the advanced settings,
the timestamps for the activity monitor flyout still display timestamps
from the default browser timezone. This PR ensures that the timestamps
display in the desired timezone.

![Screenshot 2024-10-19 at 13 35
00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)

![Screenshot 2024-10-19 at 13 36
02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)

(cherry picked from commit 7fa1e18)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.15:
- Update mappings if/when new SO types are introduced (#197061)
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 196977

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2024
… in the Advanced Settings (#196977) (#197641)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: dynamically update timestamps based on the chosen timezone in
the Advanced Settings
(#196977)](#196977)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Paulina
Shakirova","email":"paulina.shakirova@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T13:21:12Z","message":"fix:
dynamically update timestamps based on the chosen timezone in the
Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes
the\r\n[#190562](#190562) where
the\r\ncreated and updated timestamps for Dashboards do not respect the
default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if
the user changes the timezone in the advanced settings,\r\nthe
timestamps for the activity monitor flyout still display
timestamps\r\nfrom the default browser timezone. This PR ensures that
the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot
2024-10-19 at 13
35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot
2024-10-19 at 13
36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-major"],"title":"fix:
dynamically update timestamps based on the chosen timezone in the
Advanced
Settings","number":196977,"url":"https://github.com/elastic/kibana/pull/196977","mergeCommit":{"message":"fix:
dynamically update timestamps based on the chosen timezone in the
Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes
the\r\n[#190562](#190562) where
the\r\ncreated and updated timestamps for Dashboards do not respect the
default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if
the user changes the timezone in the advanced settings,\r\nthe
timestamps for the activity monitor flyout still display
timestamps\r\nfrom the default browser timezone. This PR ensures that
the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot
2024-10-19 at 13
35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot
2024-10-19 at 13
36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196977","number":196977,"mergeCommit":{"message":"fix:
dynamically update timestamps based on the chosen timezone in the
Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes
the\r\n[#190562](#190562) where
the\r\ncreated and updated timestamps for Dashboards do not respect the
default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if
the user changes the timezone in the advanced settings,\r\nthe
timestamps for the activity monitor flyout still display
timestamps\r\nfrom the default browser timezone. This PR ensures that
the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot
2024-10-19 at 13
35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot
2024-10-19 at 13
36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}}]}]
BACKPORT-->

Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 24, 2024
…e in the Advanced Settings (#196977) (#197640)

# Backport

This will backport the following commits from `main` to `8.16`:
- [fix: dynamically update timestamps based on the chosen timezone in
the Advanced Settings
(#196977)](#196977)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Paulina
Shakirova","email":"paulina.shakirova@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T13:21:12Z","message":"fix:
dynamically update timestamps based on the chosen timezone in the
Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes
the\r\n[#190562](#190562) where
the\r\ncreated and updated timestamps for Dashboards do not respect the
default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if
the user changes the timezone in the advanced settings,\r\nthe
timestamps for the activity monitor flyout still display
timestamps\r\nfrom the default browser timezone. This PR ensures that
the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot
2024-10-19 at 13
35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot
2024-10-19 at 13
36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-major"],"title":"fix:
dynamically update timestamps based on the chosen timezone in the
Advanced
Settings","number":196977,"url":"https://github.com/elastic/kibana/pull/196977","mergeCommit":{"message":"fix:
dynamically update timestamps based on the chosen timezone in the
Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes
the\r\n[#190562](#190562) where
the\r\ncreated and updated timestamps for Dashboards do not respect the
default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if
the user changes the timezone in the advanced settings,\r\nthe
timestamps for the activity monitor flyout still display
timestamps\r\nfrom the default browser timezone. This PR ensures that
the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot
2024-10-19 at 13
35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot
2024-10-19 at 13
36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196977","number":196977,"mergeCommit":{"message":"fix:
dynamically update timestamps based on the chosen timezone in the
Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes
the\r\n[#190562](#190562) where
the\r\ncreated and updated timestamps for Dashboards do not respect the
default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if
the user changes the timezone in the advanced settings,\r\nthe
timestamps for the activity monitor flyout still display
timestamps\r\nfrom the default browser timezone. This PR ensures that
the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot
2024-10-19 at 13
35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot
2024-10-19 at 13
36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}}]}]
BACKPORT-->

Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development release_note:fix Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants