[Discover][Embeddable] Pass embeddable filters to Surrounding Docs page #197190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
the
Team:DataDiscovery
jughosta
changed the title
jughosta
added
release_note:fix
backport:prev-major
jughosta
commented
Oct 22, 2024
Comment on lines
+163
to
+164
| query: savedSearchQuery, | ||
| filters: savedSearchFilters, |
There was a problem hiding this comment.
I think I kept this as it was before. We might want to consider including the current Dashboard filters for cell actions too.
There was a problem hiding this comment.
Yeah it's hard to say which behaviour is best for this. It's something worth discussing at least.
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Draft
11 tasks
davismcphee
reviewed
Oct 23, 2024
| api.fetchContext$, | ||
| stateManager.rows, | ||
| stateManager.totalHitCount, | ||
| stateManager.columnsMeta, | ||
| stateManager.grid | ||
| ); | ||
|
|
||
| // `api.query$` and `api.filters$` are the initial values from the saved search SO (as of now) |
There was a problem hiding this comment.
If api.query$ and api.filters$ already contain the saved search values, why are we switching to searchSource below?
There was a problem hiding this comment.
It seemed less verbose to me. Okay, I am going to keep the variables but reassign them to api values 4615e64
Comment on lines
+163
to
+164
| query: savedSearchQuery, | ||
| filters: savedSearchFilters, |
There was a problem hiding this comment.
Yeah it's hard to say which behaviour is best for this. It's something worth discussing at least.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @jughosta |
davismcphee
approved these changes
Oct 24, 2024
jughosta
added
v9.0.0
v8.16.0
backport:version
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11497270994 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
…ge (elastic#197190) ## Summary This PR makes sure to pass `filters` to DocViewer from the search panel on Dashboard. And DocViewer will pass `filters` over to Surrounding Docs page. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 1c3705b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
…ge (elastic#197190) ## Summary This PR makes sure to pass `filters` to DocViewer from the search panel on Dashboard. And DocViewer will pass `filters` over to Surrounding Docs page. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 1c3705b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
…ocs page (#197190) (#197594) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover][Embeddable] Pass embeddable filters to Surrounding Docs page (#197190)](#197190) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T10:16:21Z","message":"[Discover][Embeddable] Pass embeddable filters to Surrounding Docs page (#197190)\n\n## Summary\r\n\r\nThis PR makes sure to pass `filters` to DocViewer from the search panel\r\non Dashboard. And DocViewer will pass `filters` over to Surrounding Docs\r\npage.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1c3705ba5b5aa60ea451a7d0ff7f95f2d21a1b80","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:DataDiscovery","v8.16.0","backport:version","v8.17.0"],"title":"[Discover][Embeddable] Pass embeddable filters to Surrounding Docs page","number":197190,"url":"https://github.com/elastic/kibana/pull/197190","mergeCommit":{"message":"[Discover][Embeddable] Pass embeddable filters to Surrounding Docs page (#197190)\n\n## Summary\r\n\r\nThis PR makes sure to pass `filters` to DocViewer from the search panel\r\non Dashboard. And DocViewer will pass `filters` over to Surrounding Docs\r\npage.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1c3705ba5b5aa60ea451a7d0ff7f95f2d21a1b80"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197190","number":197190,"mergeCommit":{"message":"[Discover][Embeddable] Pass embeddable filters to Surrounding Docs page (#197190)\n\n## Summary\r\n\r\nThis PR makes sure to pass `filters` to DocViewer from the search panel\r\non Dashboard. And DocViewer will pass `filters` over to Surrounding Docs\r\npage.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1c3705ba5b5aa60ea451a7d0ff7f95f2d21a1b80"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
…Docs page (#197190) (#197593) # Backport This will backport the following commits from `main` to `8.16`: - [[Discover][Embeddable] Pass embeddable filters to Surrounding Docs page (#197190)](#197190) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T10:16:21Z","message":"[Discover][Embeddable] Pass embeddable filters to Surrounding Docs page (#197190)\n\n## Summary\r\n\r\nThis PR makes sure to pass `filters` to DocViewer from the search panel\r\non Dashboard. And DocViewer will pass `filters` over to Surrounding Docs\r\npage.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1c3705ba5b5aa60ea451a7d0ff7f95f2d21a1b80","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:DataDiscovery","v8.16.0","backport:version","v8.17.0"],"title":"[Discover][Embeddable] Pass embeddable filters to Surrounding Docs page","number":197190,"url":"https://github.com/elastic/kibana/pull/197190","mergeCommit":{"message":"[Discover][Embeddable] Pass embeddable filters to Surrounding Docs page (#197190)\n\n## Summary\r\n\r\nThis PR makes sure to pass `filters` to DocViewer from the search panel\r\non Dashboard. And DocViewer will pass `filters` over to Surrounding Docs\r\npage.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1c3705ba5b5aa60ea451a7d0ff7f95f2d21a1b80"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197190","number":197190,"mergeCommit":{"message":"[Discover][Embeddable] Pass embeddable filters to Surrounding Docs page (#197190)\n\n## Summary\r\n\r\nThis PR makes sure to pass `filters` to DocViewer from the search panel\r\non Dashboard. And DocViewer will pass `filters` over to Surrounding Docs\r\npage.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1c3705ba5b5aa60ea451a7d0ff7f95f2d21a1b80"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes sure to pass
filtersto DocViewer from the search panel on Dashboard. And DocViewer will passfiltersover to Surrounding Docs page.Checklist