Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Give entity store permissions to built-in and cloud roles #197383

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[Security Solution] Give entity store permissions to built-in and cloud roles #197383

merged 2 commits into from
Oct 24, 2024

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Oct 23, 2024 •
edited by kibanamachine
Loading

Summary

Give entity store permissions to built-in and cloud roles.
The entity store should be available where the RiskEngine is.

ES controller PR https://github.com/elastic/elasticsearch-controller/pull/753

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

@machadoum machadoum changed the title Add a bunch of roles [Security Solution] Give entity store permissions to built-in and cloud roles Oct 23, 2024
@machadoum machadoum marked this pull request as ready for review October 23, 2024 11:35
@machadoum machadoum requested review from a team as code owners October 23, 2024 11:35
@machadoum machadoum self-assigned this Oct 23, 2024
@machadoum machadoum added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 backport:version Backport to applied version labels v8.17.0 v9.0.0 labels Oct 23, 2024
machadoum
machadoum commented Oct 23, 2024
View reviewed changes
packages/kbn-es/src/serverless_resources/security_roles.json
"metrics-endpoint.metadata_current_*",
".fleet-agents*", ".fleet-actions*",
"risk-score.risk-score-*",
".entities.v1.latest.security_*"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only reference to the risk-score.risk-score-* index on this file. I don't know what it does, but it looks wrong to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last time I updated these files, these roles are supposed to be a copy of roles file on the project-controller repo. Looks like those Kibana roles have been moved to https://github.com/elastic/elasticsearch-controller/blob/main/helm/values.yaml.

Earlier, we used to create and merge a PR on project-controller repo before creating a role update PR on Kibana. Not sure if you'll need to do the same with this new elasticsearch-controller repo and update the relevant files.

tiansivive
tiansivive approved these changes Oct 23, 2024
View reviewed changes
...ty_solution/scripts/endpoint/common/roles_users/serverless/es_serverless_resources/roles.yml Outdated
- ".siem-signals*"
- ".lists-*"
- ".items-*"
- '.siem-signals*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change to single quote? it probably breaks the build no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just undid this change. It doesn't break anything. This file has three different patterns for index names, and my editor doesn't like them.

@jbudz
Copy link
Member

jbudz commented Oct 23, 2024

Note on the backport labels - serverless tests are only going to run on main.

@machadoum machadoum enabled auto-merge (squash) October 24, 2024 11:07
@machadoum machadoum added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: entity_analytics Feature:Entity Analytics Security Solution Entity Analytics features Team:Entity Analytics Security Entity Analytics Team labels Oct 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

ashokaditya
ashokaditya approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we didn't have to copy roles in 4 places

@machadoum machadoum merged commit a194211 into elastic:main Oct 24, 2024
56 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11498312134

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
@machadoum
[Security Solution] Give entity store permissions to built-in and clo…
0ec921b 
…ud roles (elastic#197383)

## Summary

Give entity store permissions to built-in and cloud roles.
The entity store should be available where the RiskEngine is.

ES controller PR
elastic/elasticsearch-controller#753

(cherry picked from commit a194211)
@kibanamachine kibanamachine mentioned this pull request Oct 24, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
@machadoum
[Security Solution] Give entity store permissions to built-in and clo…
4aa60d9 
…ud roles (elastic#197383)

## Summary

Give entity store permissions to built-in and cloud roles.
The entity store should be available where the RiskEngine is.

ES controller PR
elastic/elasticsearch-controller#753

(cherry picked from commit a194211)
@kibanamachine kibanamachine mentioned this pull request Oct 24, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.16
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2024
@kibanamachine @machadoum
[8.16] [Security Solution] Give entity store permissions to built-in …
e5c9769 
…and cloud roles (#197383) (#197618)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution] Give entity store permissions to built-in and
cloud roles (#197383)](#197383)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T11:25:29Z","message":"[Security
Solution] Give entity store permissions to built-in and cloud roles
(#197383)\n\n## Summary\r\n\r\nGive entity store permissions to built-in
and cloud roles.\r\nThe entity store should be available where the
RiskEngine is.\r\n\r\nES controller
PR\r\nhttps://github.com/elastic/elasticsearch-controller/pull/753","sha":"a194211fff9195c1c03c0679dc3aa806e3676515","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","Theme: entity_analytics","Feature:Entity
Analytics","Team:Entity
Analytics","v8.16.0","backport:version","v8.17.0"],"title":"[Security
Solution] Give entity store permissions to built-in and cloud
roles","number":197383,"url":"https://github.com/elastic/kibana/pull/197383","mergeCommit":{"message":"[Security
Solution] Give entity store permissions to built-in and cloud roles
(#197383)\n\n## Summary\r\n\r\nGive entity store permissions to built-in
and cloud roles.\r\nThe entity store should be available where the
RiskEngine is.\r\n\r\nES controller
PR\r\nhttps://github.com/elastic/elasticsearch-controller/pull/753","sha":"a194211fff9195c1c03c0679dc3aa806e3676515"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197383","number":197383,"mergeCommit":{"message":"[Security
Solution] Give entity store permissions to built-in and cloud roles
(#197383)\n\n## Summary\r\n\r\nGive entity store permissions to built-in
and cloud roles.\r\nThe entity store should be available where the
RiskEngine is.\r\n\r\nES controller
PR\r\nhttps://github.com/elastic/elasticsearch-controller/pull/753","sha":"a194211fff9195c1c03c0679dc3aa806e3676515"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 24, 2024
@kibanamachine @machadoum
[8.x] [Security Solution] Give entity store permissions to built-in a…
4b6de16 
…nd cloud roles (#197383) (#197619)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Give entity store permissions to built-in and
cloud roles (#197383)](#197383)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T11:25:29Z","message":"[Security
Solution] Give entity store permissions to built-in and cloud roles
(#197383)\n\n## Summary\r\n\r\nGive entity store permissions to built-in
and cloud roles.\r\nThe entity store should be available where the
RiskEngine is.\r\n\r\nES controller
PR\r\nhttps://github.com/elastic/elasticsearch-controller/pull/753","sha":"a194211fff9195c1c03c0679dc3aa806e3676515","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","Theme: entity_analytics","Feature:Entity
Analytics","Team:Entity
Analytics","v8.16.0","backport:version","v8.17.0"],"title":"[Security
Solution] Give entity store permissions to built-in and cloud
roles","number":197383,"url":"https://github.com/elastic/kibana/pull/197383","mergeCommit":{"message":"[Security
Solution] Give entity store permissions to built-in and cloud roles
(#197383)\n\n## Summary\r\n\r\nGive entity store permissions to built-in
and cloud roles.\r\nThe entity store should be available where the
RiskEngine is.\r\n\r\nES controller
PR\r\nhttps://github.com/elastic/elasticsearch-controller/pull/753","sha":"a194211fff9195c1c03c0679dc3aa806e3676515"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197383","number":197383,"mergeCommit":{"message":"[Security
Solution] Give entity store permissions to built-in and cloud roles
(#197383)\n\n## Summary\r\n\r\nGive entity store permissions to built-in
and cloud roles.\r\nThe entity store should be available where the
RiskEngine is.\r\n\r\nES controller
PR\r\nhttps://github.com/elastic/elasticsearch-controller/pull/753","sha":"a194211fff9195c1c03c0679dc3aa806e3676515"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@tiansivive tiansivive tiansivive approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

@szwarckonrad szwarckonrad Awaiting requested review from szwarckonrad szwarckonrad is a code owner automatically assigned from elastic/security-defend-workflows

@hop-dev hop-dev Awaiting requested review from hop-dev

Assignees

@machadoum machadoum

Labels
backport:version Backport to applied version labels Feature:Entity Analytics Security Solution Entity Analytics features release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: entity_analytics v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@machadoum @elasticmachine @jbudz @kibanamachine @ashokaditya @tiansivive