-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] File upload: enabling check for model allocations #197395
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
💚 Build Succeeded
Metrics [docs]
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11502602458 |
Enables the previously commented out check for `num_allocations` when listing the inference endpoints. The adaptive allocation count can drop to 0, but it is still valid for use. Uploading a file will cause it to be re-deployed. Related to es PRs elastic/elasticsearch#115233 and elastic/elasticsearch#115095 Follow on from elastic#196577 (cherry picked from commit 66b2447)
Enables the previously commented out check for `num_allocations` when listing the inference endpoints. The adaptive allocation count can drop to 0, but it is still valid for use. Uploading a file will cause it to be re-deployed. Related to es PRs elastic/elasticsearch#115233 and elastic/elasticsearch#115095 Follow on from elastic#196577 (cherry picked from commit 66b2447)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… (#197677) # Backport This will backport the following commits from `main` to `8.16`: - [[ML] File upload: enabling check for model allocations (#197395)](#197395) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T15:33:36Z","message":"[ML] File upload: enabling check for model allocations (#197395)\n\nEnables the previously commented out check for `num_allocations` when\r\nlisting the inference endpoints.\r\n\r\nThe adaptive allocation count can drop to 0, but it is still valid for\r\nuse. Uploading a file will cause it to be re-deployed.\r\n\r\nRelated to es PRs https://github.com/elastic/elasticsearch/pull/115233\r\nand https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on from https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:File and Index Data Viz","Feature:File Upload","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[ML] File upload: enabling check for model allocations","number":197395,"url":"https://github.com/elastic/kibana/pull/197395","mergeCommit":{"message":"[ML] File upload: enabling check for model allocations (#197395)\n\nEnables the previously commented out check for `num_allocations` when\r\nlisting the inference endpoints.\r\n\r\nThe adaptive allocation count can drop to 0, but it is still valid for\r\nuse. Uploading a file will cause it to be re-deployed.\r\n\r\nRelated to es PRs https://github.com/elastic/elasticsearch/pull/115233\r\nand https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on from https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197395","number":197395,"mergeCommit":{"message":"[ML] File upload: enabling check for model allocations (#197395)\n\nEnables the previously commented out check for `num_allocations` when\r\nlisting the inference endpoints.\r\n\r\nThe adaptive allocation count can drop to 0, but it is still valid for\r\nuse. Uploading a file will cause it to be re-deployed.\r\n\r\nRelated to es PRs https://github.com/elastic/elasticsearch/pull/115233\r\nand https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on from https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <jgowdy@elastic.co>
#197678) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] File upload: enabling check for model allocations (#197395)](#197395) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T15:33:36Z","message":"[ML] File upload: enabling check for model allocations (#197395)\n\nEnables the previously commented out check for `num_allocations` when\r\nlisting the inference endpoints.\r\n\r\nThe adaptive allocation count can drop to 0, but it is still valid for\r\nuse. Uploading a file will cause it to be re-deployed.\r\n\r\nRelated to es PRs https://github.com/elastic/elasticsearch/pull/115233\r\nand https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on from https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:File and Index Data Viz","Feature:File Upload","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[ML] File upload: enabling check for model allocations","number":197395,"url":"https://github.com/elastic/kibana/pull/197395","mergeCommit":{"message":"[ML] File upload: enabling check for model allocations (#197395)\n\nEnables the previously commented out check for `num_allocations` when\r\nlisting the inference endpoints.\r\n\r\nThe adaptive allocation count can drop to 0, but it is still valid for\r\nuse. Uploading a file will cause it to be re-deployed.\r\n\r\nRelated to es PRs https://github.com/elastic/elasticsearch/pull/115233\r\nand https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on from https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197395","number":197395,"mergeCommit":{"message":"[ML] File upload: enabling check for model allocations (#197395)\n\nEnables the previously commented out check for `num_allocations` when\r\nlisting the inference endpoints.\r\n\r\nThe adaptive allocation count can drop to 0, but it is still valid for\r\nuse. Uploading a file will cause it to be re-deployed.\r\n\r\nRelated to es PRs https://github.com/elastic/elasticsearch/pull/115233\r\nand https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on from https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <jgowdy@elastic.co>
Enables the previously commented out check for
num_allocations
when listing the inference endpoints.The adaptive allocation count can drop to 0, but it is still valid for use. Uploading a file will cause it to be re-deployed.
Related to es PRs elastic/elasticsearch#115233 and elastic/elasticsearch#115095
Follow on from #196577