Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [SecuritySolution] Fix issue of disappearing columns in the alerts table (#197043) #197625

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ble (elastic#197043)

## Summary

Fixes: elastic#196877

The issue above describes a situation in which columns can disappear
when toggling them in a certain order in the "Columns" and "Fields".

Steps to reproduce the original issue:

- Make sure the`file.name` column us visible in the alerts table, the
`Fields` popup and in the `Columns` selector
- Hide the `file.name` column from the `Columns` selector
- Go to `Fields` and enable the `file.name` field
- Observe that the column isn't showing up in the table
- The `file.name` column is also not showing up in the `Columns`
selector anymore.

The issue has a video demonstration attached to it as well.

With this fix applied, the column does not "disappear" anymore:

https://github.com/user-attachments/assets/4056f297-584a-4713-8936-b4e3ac3339a0

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the common scenarios

@elastic/response-ops Got any ideas on how to best add unit tests for
this?

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit d74b70f)
@kibanamachine kibanamachine merged commit e519dd8 into elastic:8.x Oct 24, 2024
26 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.7MB 1.7MB +15.0B

cc @janmonschke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants