Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Update Enterprise Search Decommissioning Callout #197658

Merged

Conversation

markjhoy
Copy link
Contributor

Summary

Updates the decommissioning callout text and makes the "Learn more" button context aware for App Search and Workplace Search.

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@markjhoy markjhoy added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Oct 24, 2024
@markjhoy markjhoy requested review from a team October 24, 2024 14:17
@markjhoy markjhoy requested review from a team as code owners October 24, 2024 14:17
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM docs wise

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (did not test locally)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 91.5KB 91.5KB +23.0B
enterpriseSearch 2.6MB 2.6MB -972.0B
lists 144.0KB 144.0KB +23.0B
total -926.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 450.3KB 450.3KB +23.0B
enterpriseSearch 55.3KB 55.4KB +125.0B
total +148.0B

History

@markjhoy markjhoy merged commit 20a83d1 into elastic:8.x Oct 24, 2024
22 checks passed
@markjhoy
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

markjhoy added a commit to markjhoy/kibana that referenced this pull request Oct 24, 2024
…lastic#197658)

## Summary

Updates the decommissioning callout text and makes the "Learn more"
button context aware for App Search and Workplace Search.

![image](https://github.com/user-attachments/assets/4871fbb3-61f1-4c39-8af0-d8964a091bca)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 20a83d1)
markjhoy added a commit that referenced this pull request Oct 25, 2024
…allout (#197658) (#197730)

# Backport

This will backport the following commits from `8.x` to `8.16`:
- [[Enterprise Search] Update Enterprise Search Decommissioning Callout
(#197658)](#197658)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mark J.
Hoy","email":"mark.hoy@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T19:10:16Z","message":"[Enterprise
Search] Update Enterprise Search Decommissioning Callout (#197658)\n\n##
Summary\r\n\r\nUpdates the decommissioning callout text and makes the
\"Learn more\"\r\nbutton context aware for App Search and Workplace
Search.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/4871fbb3-61f1-4c39-8af0-d8964a091bca)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"20a83d1785eec579f9f37a6337357d8a6eee59cd","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.16.0","backport:version","v8.17.0"],"number":197658,"url":"https://github.com/elastic/kibana/pull/197658","mergeCommit":{"message":"[Enterprise
Search] Update Enterprise Search Decommissioning Callout (#197658)\n\n##
Summary\r\n\r\nUpdates the decommissioning callout text and makes the
\"Learn more\"\r\nbutton context aware for App Search and Workplace
Search.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/4871fbb3-61f1-4c39-8af0-d8964a091bca)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"20a83d1785eec579f9f37a6337357d8a6eee59cd"}},"sourceBranch":"8.x","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.16.0 v8.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants