[CLOUD] add the term search for es in kibana #197667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
bug
XavierM
added
backport:version
💚 Build Succeeded
Metrics [docs]Page load bundle
|
|
@XavierM Just to better understand: Why both |
We realized by testing the full flow that cloud can pass by |
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11504709975 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
## Summary The cloud can pass the term `search` for the solution type. It will be ideal to only have one term but for now let's merge this fix and I will check with CP that we only pass one term for `search` and `elasticsearch`. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) (cherry picked from commit 60e3da7)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
## Summary The cloud can pass the term `search` for the solution type. It will be ideal to only have one term but for now let's merge this fix and I will check with CP that we only pass one term for `search` and `elasticsearch`. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) (cherry picked from commit 60e3da7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[CLOUD] add the term search for es in kibana (#197667)](#197667) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T17:49:14Z","message":"[CLOUD] add the term search for es in kibana (#197667)\n\n## Summary\r\n\r\nThe cloud can pass the term `search` for the solution type. It will be\r\nideal to only have one term but for now let's merge this fix and I will\r\ncheck with CP that we only pass one term for `search` and\r\n`elasticsearch`.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"60e3da73b6118e34ec250a1cb4a2f4904097b532","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Cloud","release_note:skip","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[CLOUD] add the term search for es in kibana","number":197667,"url":"https://github.com/elastic/kibana/pull/197667","mergeCommit":{"message":"[CLOUD] add the term search for es in kibana (#197667)\n\n## Summary\r\n\r\nThe cloud can pass the term `search` for the solution type. It will be\r\nideal to only have one term but for now let's merge this fix and I will\r\ncheck with CP that we only pass one term for `search` and\r\n`elasticsearch`.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"60e3da73b6118e34ec250a1cb4a2f4904097b532"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197667","number":197667,"mergeCommit":{"message":"[CLOUD] add the term search for es in kibana (#197667)\n\n## Summary\r\n\r\nThe cloud can pass the term `search` for the solution type. It will be\r\nideal to only have one term but for now let's merge this fix and I will\r\ncheck with CP that we only pass one term for `search` and\r\n`elasticsearch`.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"60e3da73b6118e34ec250a1cb4a2f4904097b532"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[CLOUD] add the term search for es in kibana (#197667)](#197667) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T17:49:14Z","message":"[CLOUD] add the term search for es in kibana (#197667)\n\n## Summary\r\n\r\nThe cloud can pass the term `search` for the solution type. It will be\r\nideal to only have one term but for now let's merge this fix and I will\r\ncheck with CP that we only pass one term for `search` and\r\n`elasticsearch`.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"60e3da73b6118e34ec250a1cb4a2f4904097b532","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Cloud","release_note:skip","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[CLOUD] add the term search for es in kibana","number":197667,"url":"https://github.com/elastic/kibana/pull/197667","mergeCommit":{"message":"[CLOUD] add the term search for es in kibana (#197667)\n\n## Summary\r\n\r\nThe cloud can pass the term `search` for the solution type. It will be\r\nideal to only have one term but for now let's merge this fix and I will\r\ncheck with CP that we only pass one term for `search` and\r\n`elasticsearch`.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"60e3da73b6118e34ec250a1cb4a2f4904097b532"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197667","number":197667,"mergeCommit":{"message":"[CLOUD] add the term search for es in kibana (#197667)\n\n## Summary\r\n\r\nThe cloud can pass the term `search` for the solution type. It will be\r\nideal to only have one term but for now let's merge this fix and I will\r\ncheck with CP that we only pass one term for `search` and\r\n`elasticsearch`.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"60e3da73b6118e34ec250a1cb4a2f4904097b532"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
XavierM
added a commit
that referenced
this pull request
Nov 27, 2024
## Summary We are having the same issue as here #197667 for instant deployment. We need to allow the solution_type `search`. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 27, 2024
## Summary We are having the same issue as here elastic#197667 for instant deployment. We need to allow the solution_type `search`. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 54d4698)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 27, 2024
## Summary We are having the same issue as here elastic#197667 for instant deployment. We need to allow the solution_type `search`. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 54d4698)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 27, 2024
## Summary We are having the same issue as here elastic#197667 for instant deployment. We need to allow the solution_type `search`. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 54d4698)
kibanamachine
added a commit
that referenced
this pull request
Nov 27, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[CLOUD] Instant deployment (#201688)](#201688) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2024-11-27T13:08:08Z","message":"[CLOUD] Instant deployment (#201688)\n\n## Summary\r\n\r\nWe are having the same issue as here\r\nhttps://github.com//pull/197667 for instant deployment. We\r\nneed to allow the solution_type `search`.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54d46986e676c0a824ac20204391f0212e59c880","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Cloud","v9.0.0","backport:version","v8.17.0","v8.18.0","v8.16.2"],"title":"[CLOUD] Instant deployment","number":201688,"url":"https://github.com/elastic/kibana/pull/201688","mergeCommit":{"message":"[CLOUD] Instant deployment (#201688)\n\n## Summary\r\n\r\nWe are having the same issue as here\r\nhttps://github.com//pull/197667 for instant deployment. We\r\nneed to allow the solution_type `search`.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54d46986e676c0a824ac20204391f0212e59c880"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201688","number":201688,"mergeCommit":{"message":"[CLOUD] Instant deployment (#201688)\n\n## Summary\r\n\r\nWe are having the same issue as here\r\nhttps://github.com//pull/197667 for instant deployment. We\r\nneed to allow the solution_type `search`.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54d46986e676c0a824ac20204391f0212e59c880"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Nov 27, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[CLOUD] Instant deployment (#201688)](#201688) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2024-11-27T13:08:08Z","message":"[CLOUD] Instant deployment (#201688)\n\n## Summary\r\n\r\nWe are having the same issue as here\r\nhttps://github.com//pull/197667 for instant deployment. We\r\nneed to allow the solution_type `search`.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54d46986e676c0a824ac20204391f0212e59c880","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Cloud","v9.0.0","backport:version","v8.17.0","v8.18.0","v8.16.2"],"title":"[CLOUD] Instant deployment","number":201688,"url":"https://github.com/elastic/kibana/pull/201688","mergeCommit":{"message":"[CLOUD] Instant deployment (#201688)\n\n## Summary\r\n\r\nWe are having the same issue as here\r\nhttps://github.com//pull/197667 for instant deployment. We\r\nneed to allow the solution_type `search`.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54d46986e676c0a824ac20204391f0212e59c880"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201688","number":201688,"mergeCommit":{"message":"[CLOUD] Instant deployment (#201688)\n\n## Summary\r\n\r\nWe are having the same issue as here\r\nhttps://github.com//pull/197667 for instant deployment. We\r\nneed to allow the solution_type `search`.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54d46986e676c0a824ac20204391f0212e59c880"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Nov 27, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[CLOUD] Instant deployment (#201688)](#201688) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2024-11-27T13:08:08Z","message":"[CLOUD] Instant deployment (#201688)\n\n## Summary\r\n\r\nWe are having the same issue as here\r\nhttps://github.com//pull/197667 for instant deployment. We\r\nneed to allow the solution_type `search`.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54d46986e676c0a824ac20204391f0212e59c880","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Cloud","v9.0.0","backport:version","v8.17.0","v8.18.0","v8.16.2"],"title":"[CLOUD] Instant deployment","number":201688,"url":"https://github.com/elastic/kibana/pull/201688","mergeCommit":{"message":"[CLOUD] Instant deployment (#201688)\n\n## Summary\r\n\r\nWe are having the same issue as here\r\nhttps://github.com//pull/197667 for instant deployment. We\r\nneed to allow the solution_type `search`.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54d46986e676c0a824ac20204391f0212e59c880"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201688","number":201688,"mergeCommit":{"message":"[CLOUD] Instant deployment (#201688)\n\n## Summary\r\n\r\nWe are having the same issue as here\r\nhttps://github.com//pull/197667 for instant deployment. We\r\nneed to allow the solution_type `search`.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54d46986e676c0a824ac20204391f0212e59c880"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The cloud can pass the term
searchfor the solution type. It will be ideal to only have one term but for now let's merge this fix and I will check with CP that we only pass one term forsearchandelasticsearch.Checklist
Delete any items that are not applicable to this PR.