Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x][Core] [UA] Support API Deprecations #196081 #198210

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Oct 29, 2024

Summary

Backport #196081

@Bamieh Bamieh requested review from a team as code owners October 29, 2024 21:54
@Bamieh Bamieh requested review from joeypoon and gergoabraham and removed request for a team October 29, 2024 21:54
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-http-server 216 232 +16
@kbn/core-usage-data-server 144 154 +10
total +26

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 157.2KB 158.8KB +1.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/core-deprecations-common 0 1 +1
@kbn/core-http-server 0 1 +1
total +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 450.3KB 450.8KB +519.0B
Unknown metric groups

API count

id before after diff
@kbn/core-http-server 534 552 +18
@kbn/core-usage-data-server 155 165 +10
total +28

ESLint disabled in files

id before after diff
@kbn/core-deprecations-server-internal 2 1 -1

Total ESLint disabled count

id before after diff
@kbn/core-deprecations-server-internal 2 1 -1

@Bamieh Bamieh merged commit 21dd620 into elastic:8.x Oct 30, 2024
35 checks passed
@Bamieh Bamieh deleted the 8_x_core/api-deprecations branch October 30, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants