Ang/pie options eui2 #19846
Closed
Ang/pie options eui2 #19846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the accordion (unecessary as there is still a lot of space available) - Added section headers - Wrapped in a EuiPanel - Disabling all other label setting controls if the “Show labels” is off - Changing all labels to sentence case (only first word should be capitalized)
💔 Build Failed |
|
I agree, this is a poor user experience when switching context and would be perceived as a regression and annoyance in converting to our clean, new EUI. Given upcoming discussions around EUI, it might make sense to hold off for now on this implementation. To me, I'd prefer to wait for the EUI bug to be resolved before introducing to the UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variation of #18579
ng-if is used instead of ng-show in editor, which means that when switching the tabs information about collapsed/expanded panels is lost.
this is done to work around the blocking EUI bug: elastic/eui#805
in my opinion the user experience is much worse like this and would vote against going forward with this and rather wait for the EUI bug to be resolved.