[APM] Foundation for migrating APM tests to deployment agnostic approach #198775

crespocarlos · 2024-11-04T12:50:56Z

part of #193245
closes #198958

Summary

This PR lays the foundation to start migrating APM API integration tests to the deployment agnostic approach.

How to test

Serverless

node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM API tests"

It's recommended to be run against MKI

Stateful

node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM API tests"

Migrate agent_explorer test Update latest_agent_versions test

crespocarlos · 2024-11-04T13:35:56Z

/ci

…fix'

crespocarlos · 2024-11-04T14:25:15Z

/ci

crespocarlos · 2024-11-05T10:52:04Z

/ci

crespocarlos · 2024-11-05T11:56:48Z

@elasticmachine merge upstream

crespocarlos · 2024-11-05T12:29:13Z

/ci

kpatticha · 2024-11-05T14:00:50Z

@crespocarlos can you please add in the description how to run these tests. 🙏

crespocarlos · 2024-11-05T14:04:50Z

@crespocarlos can you please add in the description how to run these tests. 🙏

Will do when I open the PR for review :)

…fix'

…oyment-agnostic-tests-part-1

dmlemeshko

Great progress, Carlos 🚀

Thanks a lot for reaching us and making changes. I left some questions

...tion/deployment_agnostic/apis/observability/apm/agent_explorer/latest_agent_versions.spec.ts

...integration/deployment_agnostic/apis/observability/apm/agent_explorer/agent_explorer.spec.ts

dmlemeshko · 2024-11-06T09:52:29Z

x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/index.ts

+  // Skipping here will skip the entire apm api test suite
+  // Instead skip (flaky) tests individually
+  // Failing: See https://github.com/elastic/kibana/issues/176948
+  describe('APM API tests', function () {


Totally up to you about the naming, just since it is located in x-pack/test/api_integration you can probably omit API word.

x-pack/test/api_integration/deployment_agnostic/services/apm_api.ts

dmlemeshko

Sorry, but have to double check about Infra tests update.

...tion/deployment_agnostic/apis/observability/apm/agent_explorer/latest_agent_versions.spec.ts

crespocarlos · 2024-11-06T14:47:27Z

Sorry, but have to double check about Infra tests update.

#198775 (comment)

crespocarlos · 2024-11-06T14:50:20Z

@elasticmachine merge upstream

dmlemeshko

LGTM

On behalf of Appex-QA, thank you for being open to feedback and doing few rounds of changes

elasticmachine · 2024-11-06T15:46:56Z

💚 Build Succeeded

Buildkite Build
Commit: 47795a1
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-198775-47795a1db0a9

Metrics [docs]

✅ unchanged

History

💚 Build #248810 succeeded 9f531aa
💚 Build #248720 succeeded 76262fa
💔 Build #248715 failed 13474b9
💚 Build #248596 succeeded 980adb6
💚 Build #248430 succeeded 06e7f74

kibanamachine · 2024-11-06T16:38:37Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11707967174

kibanamachine · 2024-11-06T16:43:39Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 198775

Questions ?

Please refer to the Backport tool documentation

…ach (elastic#198775) part of elastic#193245 closes elastic#198958 ## Summary This PR lays the foundation to start migrating APM API integration tests to the deployment agnostic approach. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM API tests" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM API tests" ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

kibanamachine · 2024-11-07T16:49:23Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 198775 locally

kibanamachine · 2024-11-08T17:48:48Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 198775 locally

…ach (elastic#198775) part of elastic#193245 closes elastic#198958 ## Summary This PR lays the foundation to start migrating APM API integration tests to the deployment agnostic approach. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM API tests" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM API tests" ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 926861b)

… approach (#198775) (#199637) # Backport This will backport the following commits from `main` to `8.x`: - [[APM] Foundation for migrating APM tests to deployment agnostic approach (#198775)](#198775)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)

crespocarlos force-pushed the 193245-apm-deployment-agnostic-tests-part-1 branch 9 times, most recently from 2393507 to 5277183 Compare November 4, 2024 13:25

Add foundation to run apm tests

eee7cd3

Migrate agent_explorer test Update latest_agent_versions test

crespocarlos force-pushed the 193245-apm-deployment-agnostic-tests-part-1 branch from 5277183 to eee7cd3 Compare November 4, 2024 13:26

crespocarlos added 2 commits November 4, 2024 14:27

Force Git to recognize latest_agent_versions.spec.ts as moved

5857da2

Updated latest_agent_versions.spec.ts after moving

c45c662

kibanamachine and others added 3 commits November 4, 2024 13:47

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

66f5e4c

…fix'

Simplify apmApi

17fb5e2

Symplify createApmSynthtraceEsClient

4d684c6

crespocarlos changed the title ~~[APM] Deployment agnostic tests part 1~~ [APM] Foundation for migrating APM tests to deployment agnostic approach Nov 4, 2024

Merge branch 'main' into 193245-apm-deployment-agnostic-tests-part-1

06e7f74

crespocarlos added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 5, 2024

crespocarlos marked this pull request as ready for review November 5, 2024 15:09

crespocarlos requested a review from a team as a code owner November 5, 2024 15:09

crespocarlos and others added 4 commits November 5, 2024 19:36

Remove registry service

c2b1f1f

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

980adb6

…fix'

Merge branch 'main' of github.com:elastic/kibana into 193245-apm-depl…

13474b9

…oyment-agnostic-tests-part-1

Fix after merge

76262fa

dmlemeshko reviewed Nov 6, 2024

View reviewed changes

dmlemeshko mentioned this pull request Nov 6, 2024

[APM] Migrate /mobile API tests to deployment agnostic folder #199021

Merged

3 tasks

crespocarlos added 2 commits November 6, 2024 13:52

Fix Infra and APM api calls

8f40435

Revert change

9f531aa

crespocarlos requested a review from dmlemeshko November 6, 2024 13:00

dmlemeshko reviewed Nov 6, 2024

View reviewed changes

...tion/deployment_agnostic/apis/observability/apm/agent_explorer/latest_agent_versions.spec.ts Show resolved Hide resolved

crespocarlos requested a review from dmlemeshko November 6, 2024 13:40

Merge branch 'main' into 193245-apm-deployment-agnostic-tests-part-1

47795a1

dmlemeshko approved these changes Nov 6, 2024

View reviewed changes

crespocarlos enabled auto-merge (squash) November 6, 2024 14:58

crespocarlos merged commit 926861b into elastic:main Nov 6, 2024
23 checks passed

kibanamachine added the v9.0.0 label Nov 6, 2024

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 7, 2024

crespocarlos mentioned this pull request Nov 11, 2024

[8.x] [APM] Foundation for migrating APM tests to deployment agnostic approach (#198775) #199637

Merged

kibanamachine added v8.17.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Foundation for migrating APM tests to deployment agnostic approach #198775

[APM] Foundation for migrating APM tests to deployment agnostic approach #198775

crespocarlos commented Nov 4, 2024 •

edited by kibanamachine

Loading

crespocarlos commented Nov 4, 2024

crespocarlos commented Nov 4, 2024

crespocarlos commented Nov 5, 2024

crespocarlos commented Nov 5, 2024

crespocarlos commented Nov 5, 2024

kpatticha commented Nov 5, 2024

crespocarlos commented Nov 5, 2024

dmlemeshko left a comment

dmlemeshko Nov 6, 2024

dmlemeshko left a comment

crespocarlos commented Nov 6, 2024

crespocarlos commented Nov 6, 2024

dmlemeshko left a comment

elasticmachine commented Nov 6, 2024 •

edited

Loading

kibanamachine commented Nov 6, 2024

kibanamachine commented Nov 6, 2024

kibanamachine commented Nov 7, 2024

kibanamachine commented Nov 8, 2024

[APM] Foundation for migrating APM tests to deployment agnostic approach #198775

[APM] Foundation for migrating APM tests to deployment agnostic approach #198775

Conversation

crespocarlos commented Nov 4, 2024 • edited by kibanamachine Loading

Summary

How to test

crespocarlos commented Nov 4, 2024

crespocarlos commented Nov 4, 2024

crespocarlos commented Nov 5, 2024

crespocarlos commented Nov 5, 2024

crespocarlos commented Nov 5, 2024

kpatticha commented Nov 5, 2024

crespocarlos commented Nov 5, 2024

dmlemeshko left a comment

Choose a reason for hiding this comment

dmlemeshko Nov 6, 2024

Choose a reason for hiding this comment

dmlemeshko left a comment

Choose a reason for hiding this comment

crespocarlos commented Nov 6, 2024

crespocarlos commented Nov 6, 2024

dmlemeshko left a comment

Choose a reason for hiding this comment

elasticmachine commented Nov 6, 2024 • edited Loading

💚 Build Succeeded

Metrics [docs]

History

kibanamachine commented Nov 6, 2024

kibanamachine commented Nov 6, 2024

💔 All backports failed

Manual backport

Questions ?

kibanamachine commented Nov 7, 2024

kibanamachine commented Nov 8, 2024

crespocarlos commented Nov 4, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Nov 6, 2024 •

edited

Loading