-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ilm] Remove observability solution dependency on index lifecycle management plugin bundle #199383
Conversation
/ci |
/ci |
/ci |
/ci |
Pinging @elastic/kibana-management (Team:Kibana Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import changes LGTM!
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana.jsonc
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm, tested ILM app locally.
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
cc @mattkime |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11770897866 |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…agement plugin bundle (elastic#199383) Create package for observability solution's dependencies from index lifecycle management. Previously it relied on the plugin bundle but thats best avoided with our sustainable architecture efforts. Part of elastic/kibana-team#1179 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d805546) # Conflicts: # .github/CODEOWNERS
…agement plugin bundle (elastic#199383) Create package for observability solution's dependencies from index lifecycle management. Previously it relied on the plugin bundle but thats best avoided with our sustainable architecture efforts. Part of elastic/kibana-team#1179 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Friendly reminder: Looks like this PR hasn’t been backported yet. |
…agement plugin bundle (elastic#199383) Create package for observability solution's dependencies from index lifecycle management. Previously it relied on the plugin bundle but thats best avoided with our sustainable architecture efforts. Part of elastic/kibana-team#1179 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…agement plugin bundle (elastic#199383) Create package for observability solution's dependencies from index lifecycle management. Previously it relied on the plugin bundle but thats best avoided with our sustainable architecture efforts. Part of elastic/kibana-team#1179 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d805546) # Conflicts: # .github/CODEOWNERS # package.json # tsconfig.base.json # yarn.lock
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
…le management plugin bundle (#199383) (#199986) # Backport This will backport the following commits from `main` to `8.x`: - [[ilm] Remove observability solution dependency on index lifecycle management plugin bundle (#199383)](#199383) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2024-11-11T02:18:49Z","message":"[ilm] Remove observability solution dependency on index lifecycle management plugin bundle (#199383)\n\nCreate package for observability solution's dependencies from index\r\nlifecycle management. Previously it relied on the plugin bundle but\r\nthats best avoided with our sustainable architecture efforts.\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1179\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d8055465071542e84059250aecc8f8fc81bf72f4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:ILM","Team:Kibana Management","release_note:skip","backport missing","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"number":199383,"url":"https://github.com/elastic/kibana/pull/199383","mergeCommit":{"message":"[ilm] Remove observability solution dependency on index lifecycle management plugin bundle (#199383)\n\nCreate package for observability solution's dependencies from index\r\nlifecycle management. Previously it relied on the plugin bundle but\r\nthats best avoided with our sustainable architecture efforts.\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1179\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d8055465071542e84059250aecc8f8fc81bf72f4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199383","number":199383,"mergeCommit":{"message":"[ilm] Remove observability solution dependency on index lifecycle management plugin bundle (#199383)\n\nCreate package for observability solution's dependencies from index\r\nlifecycle management. Previously it relied on the plugin bundle but\r\nthats best avoided with our sustainable architecture efforts.\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1179\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d8055465071542e84059250aecc8f8fc81bf72f4"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Create package for observability solution's dependencies from index lifecycle management. Previously it relied on the plugin bundle but thats best avoided with our sustainable architecture efforts.
Part of https://github.com/elastic/kibana-team/issues/1179