[ES|QL] Group by histogram suggestion first in the list #199611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
release_note:skip
|
Pinging @elastic/kibana-esql (Team:ESQL) |
💚 Build Succeeded
Metrics [docs]Page load bundle
|
vadimkibana
approved these changes
Nov 12, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11793069719 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
## Summary Ensures that group BY histogram suggestion is first on the list. It fixes a regression caused from the refactoring of autocomplete <img width="1108" alt="image" src="https://github.com/user-attachments/assets/a6d6ba7b-c346-4d07-98f4-ac4c4b3ae857"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit e87fbd8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2024
… (#199731) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Group by histogram suggestion first in the list (#199611)](#199611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-11-12T08:03:50Z","message":"[ES|QL] Group by histogram suggestion first in the list (#199611)\n\n## Summary\r\n\r\nEnsures that group BY histogram suggestion is first on the list. It\r\nfixes a regression caused from the refactoring of autocomplete\r\n\r\n\r\n<img width=\"1108\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a6d6ba7b-c346-4d07-98f4-ac4c4b3ae857\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e87fbd8c241d9327df6dc4ad1942447fa99276fb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.17.0"],"title":"[ES|QL] Group by histogram suggestion first in the list","number":199611,"url":"https://github.com/elastic/kibana/pull/199611","mergeCommit":{"message":"[ES|QL] Group by histogram suggestion first in the list (#199611)\n\n## Summary\r\n\r\nEnsures that group BY histogram suggestion is first on the list. It\r\nfixes a regression caused from the refactoring of autocomplete\r\n\r\n\r\n<img width=\"1108\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a6d6ba7b-c346-4d07-98f4-ac4c4b3ae857\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e87fbd8c241d9327df6dc4ad1942447fa99276fb"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199611","number":199611,"mergeCommit":{"message":"[ES|QL] Group by histogram suggestion first in the list (#199611)\n\n## Summary\r\n\r\nEnsures that group BY histogram suggestion is first on the list. It\r\nfixes a regression caused from the refactoring of autocomplete\r\n\r\n\r\n<img width=\"1108\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a6d6ba7b-c346-4d07-98f4-ac4c4b3ae857\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e87fbd8c241d9327df6dc4ad1942447fa99276fb"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Nov 12, 2024
## Summary Ensures that group BY histogram suggestion is first on the list. It fixes a regression caused from the refactoring of autocomplete <img width="1108" alt="image" src="https://github.com/user-attachments/assets/a6d6ba7b-c346-4d07-98f4-ac4c4b3ae857"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
## Summary Ensures that group BY histogram suggestion is first on the list. It fixes a regression caused from the refactoring of autocomplete <img width="1108" alt="image" src="https://github.com/user-attachments/assets/a6d6ba7b-c346-4d07-98f4-ac4c4b3ae857"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that group BY histogram suggestion is first on the list. It fixes a regression caused from the refactoring of autocomplete
Checklist