-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs] Deprecation warning for Logs Explorer and Logs Stream #199652
[Logs] Deprecation warning for Logs Explorer and Logs Stream #199652
Conversation
x-pack/plugins/observability_solution/infra/common/ui_settings.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/observability_logs_explorer/common/translations.ts
Outdated
Show resolved
Hide resolved
@mdbirnstiehl I tagged you on some lines where there are changes on the copies, I'd appreciate if you could take a look please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments/ideas. Let me know if I've not gotten the right message across in any of these or if you need something reworked.
x-pack/plugins/observability_solution/infra/common/ui_settings.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/observability_logs_explorer/common/translations.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/observability_logs_explorer/common/translations.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
…logs_deprecation_callout.tsx Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
…logs_deprecation_callout.tsx Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
…rer/common/translations.ts Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
…rer/common/translations.ts Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Thanks for the suggestions @mdbirnstiehl! |
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11798220362 |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…#199652) ## 📓 Summary Closes elastic/observability-dev#4070 - Update the deprecation callouts to suggest that the user use Discover. - Replace the beta badge in Logs Explorer with a deprecation notice. - Mark the advanced setting to enable the log stream to be deprecated. <img width="844" alt="Screenshot 2024-11-11 at 15 22 51" src="https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5"> --------- Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…#199652) ## 📓 Summary Closes elastic/observability-dev#4070 - Update the deprecation callouts to suggest that the user use Discover. - Replace the beta badge in Logs Explorer with a deprecation notice. - Mark the advanced setting to enable the log stream to be deprecated. <img width="844" alt="Screenshot 2024-11-11 at 15 22 51" src="https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5"> --------- Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com> (cherry picked from commit 9975c55) # Conflicts: # x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx
…199652) (#200016) # Backport This will backport the following commits from `main` to `8.x`: - [[Logs] Deprecation warning for Logs Explorer and Logs Stream (#199652)](#199652) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2024-11-12T13:25:09Z","message":"[Logs] Deprecation warning for Logs Explorer and Logs Stream (#199652)\n\n## 📓 Summary\r\n\r\nCloses https://github.com/elastic/observability-dev/issues/4070\r\n\r\n- Update the deprecation callouts to suggest that the user use Discover.\r\n- Replace the beta badge in Logs Explorer with a deprecation notice.\r\n- Mark the advanced setting to enable the log stream to be deprecated.\r\n\r\n<img width=\"844\" alt=\"Screenshot 2024-11-11 at 15 22 51\"\r\nsrc=\"https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5\">\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>\r\nCo-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>","sha":"9975c552da13e778b82ffa91d1a6fe1de8cac4a6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"number":199652,"url":"https://github.com/elastic/kibana/pull/199652","mergeCommit":{"message":"[Logs] Deprecation warning for Logs Explorer and Logs Stream (#199652)\n\n## 📓 Summary\r\n\r\nCloses https://github.com/elastic/observability-dev/issues/4070\r\n\r\n- Update the deprecation callouts to suggest that the user use Discover.\r\n- Replace the beta badge in Logs Explorer with a deprecation notice.\r\n- Mark the advanced setting to enable the log stream to be deprecated.\r\n\r\n<img width=\"844\" alt=\"Screenshot 2024-11-11 at 15 22 51\"\r\nsrc=\"https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5\">\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>\r\nCo-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>","sha":"9975c552da13e778b82ffa91d1a6fe1de8cac4a6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199652","number":199652,"mergeCommit":{"message":"[Logs] Deprecation warning for Logs Explorer and Logs Stream (#199652)\n\n## 📓 Summary\r\n\r\nCloses https://github.com/elastic/observability-dev/issues/4070\r\n\r\n- Update the deprecation callouts to suggest that the user use Discover.\r\n- Replace the beta badge in Logs Explorer with a deprecation notice.\r\n- Mark the advanced setting to enable the log stream to be deprecated.\r\n\r\n<img width=\"844\" alt=\"Screenshot 2024-11-11 at 15 22 51\"\r\nsrc=\"https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5\">\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>\r\nCo-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>","sha":"9975c552da13e778b82ffa91d1a6fe1de8cac4a6"}}]}] BACKPORT-->
…#199652) ## 📓 Summary Closes elastic/observability-dev#4070 - Update the deprecation callouts to suggest that the user use Discover. - Replace the beta badge in Logs Explorer with a deprecation notice. - Mark the advanced setting to enable the log stream to be deprecated. <img width="844" alt="Screenshot 2024-11-11 at 15 22 51" src="https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5"> --------- Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
📓 Summary
Closes https://github.com/elastic/observability-dev/issues/4070