Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs] Deprecation warning for Logs Explorer and Logs Stream #199652

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Nov 11, 2024

📓 Summary

Closes https://github.com/elastic/observability-dev/issues/4070

  • Update the deprecation callouts to suggest that the user use Discover.
  • Replace the beta badge in Logs Explorer with a deprecation notice.
  • Mark the advanced setting to enable the log stream to be deprecated.
Screenshot 2024-11-11 at 15 22 51

@tonyghiani
Copy link
Contributor Author

@mdbirnstiehl I tagged you on some lines where there are changes on the copies, I'd appreciate if you could take a look please!

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments/ideas. Let me know if I've not gotten the right message across in any of these or if you need something reworked.

tonyghiani and others added 5 commits November 12, 2024 09:57
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
…logs_deprecation_callout.tsx

Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
…logs_deprecation_callout.tsx

Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
…rer/common/translations.ts

Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
…rer/common/translations.ts

Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
@tonyghiani
Copy link
Contributor Author

Thanks for the suggestions @mdbirnstiehl!

@tonyghiani tonyghiani marked this pull request as ready for review November 12, 2024 09:38
@tonyghiani tonyghiani requested review from a team as code owners November 12, 2024 09:38
@tonyghiani tonyghiani added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-logs Observability Logs User Experience Team labels Nov 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 12, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.7MB 1.7MB -216.0B
observabilityLogsExplorer 147.1KB 147.1KB +26.0B
total -190.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 56.3KB 56.4KB +138.0B
observabilityLogsExplorer 14.9KB 15.3KB +336.0B
total +474.0B

Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyghiani tonyghiani merged commit 9975c55 into elastic:main Nov 12, 2024
30 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11798220362

@tonyghiani tonyghiani deleted the 4070-deprecation-warning-logs-explorer-and-log-stream branch November 12, 2024 13:25
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 199652

Questions ?

Please refer to the Backport tool documentation

tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Nov 12, 2024
…#199652)

## 📓 Summary

Closes elastic/observability-dev#4070

- Update the deprecation callouts to suggest that the user use Discover.
- Replace the beta badge in Logs Explorer with a deprecation notice.
- Mark the advanced setting to enable the log stream to be deprecated.

<img width="844" alt="Screenshot 2024-11-11 at 15 22 51"
src="https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5">

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 13, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 199652 locally

@tonyghiani
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

tonyghiani added a commit to tonyghiani/kibana that referenced this pull request Nov 13, 2024
…#199652)

## 📓 Summary

Closes elastic/observability-dev#4070

- Update the deprecation callouts to suggest that the user use Discover.
- Replace the beta badge in Logs Explorer with a deprecation notice.
- Mark the advanced setting to enable the log stream to be deprecated.

<img width="844" alt="Screenshot 2024-11-11 at 15 22 51"
src="https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5">

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
(cherry picked from commit 9975c55)

# Conflicts:
#	x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx
tonyghiani added a commit that referenced this pull request Nov 14, 2024
…199652) (#200016)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Logs] Deprecation warning for Logs Explorer and Logs Stream
(#199652)](#199652)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2024-11-12T13:25:09Z","message":"[Logs]
Deprecation warning for Logs Explorer and Logs Stream (#199652)\n\n## 📓
Summary\r\n\r\nCloses
https://github.com/elastic/observability-dev/issues/4070\r\n\r\n- Update
the deprecation callouts to suggest that the user use Discover.\r\n-
Replace the beta badge in Logs Explorer with a deprecation notice.\r\n-
Mark the advanced setting to enable the log stream to be
deprecated.\r\n\r\n<img width=\"844\" alt=\"Screenshot 2024-11-11 at 15
22
51\"\r\nsrc=\"https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>\r\nCo-authored-by:
Mike Birnstiehl
<114418652+mdbirnstiehl@users.noreply.github.com>","sha":"9975c552da13e778b82ffa91d1a6fe1de8cac4a6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"number":199652,"url":"https://github.com/elastic/kibana/pull/199652","mergeCommit":{"message":"[Logs]
Deprecation warning for Logs Explorer and Logs Stream (#199652)\n\n## 📓
Summary\r\n\r\nCloses
https://github.com/elastic/observability-dev/issues/4070\r\n\r\n- Update
the deprecation callouts to suggest that the user use Discover.\r\n-
Replace the beta badge in Logs Explorer with a deprecation notice.\r\n-
Mark the advanced setting to enable the log stream to be
deprecated.\r\n\r\n<img width=\"844\" alt=\"Screenshot 2024-11-11 at 15
22
51\"\r\nsrc=\"https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>\r\nCo-authored-by:
Mike Birnstiehl
<114418652+mdbirnstiehl@users.noreply.github.com>","sha":"9975c552da13e778b82ffa91d1a6fe1de8cac4a6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199652","number":199652,"mergeCommit":{"message":"[Logs]
Deprecation warning for Logs Explorer and Logs Stream (#199652)\n\n## 📓
Summary\r\n\r\nCloses
https://github.com/elastic/observability-dev/issues/4070\r\n\r\n- Update
the deprecation callouts to suggest that the user use Discover.\r\n-
Replace the beta badge in Logs Explorer with a deprecation notice.\r\n-
Mark the advanced setting to enable the log stream to be
deprecated.\r\n\r\n<img width=\"844\" alt=\"Screenshot 2024-11-11 at 15
22
51\"\r\nsrc=\"https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>\r\nCo-authored-by:
Mike Birnstiehl
<114418652+mdbirnstiehl@users.noreply.github.com>","sha":"9975c552da13e778b82ffa91d1a6fe1de8cac4a6"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added v8.17.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 14, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
…#199652)

## 📓 Summary

Closes elastic/observability-dev#4070

- Update the deprecation callouts to suggest that the user use Discover.
- Replace the beta badge in Logs Explorer with a deprecation notice.
- Mark the advanced setting to enable the log stream to be deprecated.

<img width="844" alt="Screenshot 2024-11-11 at 15 22 51"
src="https://github.com/user-attachments/assets/5f8a4858-cad5-4d75-9868-d1c9d54a9ce5">

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants