[DataUsage][Serverless] Fix auto ops URL path suffix #200192
Merged
+133
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokaditya
added
release_note:skip
neptunian
reviewed
Nov 14, 2024
ashokaditya
force-pushed
the
task/fix-data-usage-autoops-api-integration-path
branch
from
b485396 to
af7c1c3
Compare
ashokaditya
force-pushed
the
task/fix-data-usage-autoops-api-integration-path
branch
from
af7c1c3 to
5ce1b98
Compare
YulNaumenko
approved these changes
Nov 14, 2024
neptunian
approved these changes
Nov 14, 2024
YulNaumenko
reviewed
Nov 18, 2024
| return async (context, _, response) => { | ||
| const logger = dataUsageContext.logFactory.get('dataStreamsRoute'); |
There was a problem hiding this comment.
It could be moved to the handler now as it was before (line 17)
YulNaumenko
reviewed
Nov 18, 2024
| return async (context, request, response) => { | ||
| const logger = dataUsageContext.logFactory.get('usageMetricsRoute'); |
There was a problem hiding this comment.
same here, please move it to the handler level.
💚 Build Succeeded
Metrics [docs]
History
cc @ashokaditya |
TinaHeiligers
approved these changes
Nov 18, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11899865929 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
## Summary Updates the autoops URL path suffix. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: YulNaumenko <jo.naumenko@gmail.com> Co-authored-by: neptunian <sandra.gonzales@elastic.co> Co-authored-by: Sandra G <neptunian@users.noreply.github.com> (cherry picked from commit f4d74ec)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ashokaditya
deleted the
task/fix-data-usage-autoops-api-integration-path
branch
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
…200643) # Backport This will backport the following commits from `main` to `8.x`: - [[DataUsage][Serverless] Fix auto ops URL path suffix (#200192)](#200192) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-18T19:42:59Z","message":"[DataUsage][Serverless] Fix auto ops URL path suffix (#200192)\n\n## Summary\r\n\r\nUpdates the autoops URL path suffix.\r\n\r\n### Checklist\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: YulNaumenko <jo.naumenko@gmail.com>\r\nCo-authored-by: neptunian <sandra.gonzales@elastic.co>\r\nCo-authored-by: Sandra G <neptunian@users.noreply.github.com>","sha":"f4d74ec4a8a336264f4e37a07b38bcd524bfad8e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:build-serverless-image","backport:version","v8.17.0"],"title":"[DataUsage][Serverless] Fix auto ops URL path suffix","number":200192,"url":"https://github.com/elastic/kibana/pull/200192","mergeCommit":{"message":"[DataUsage][Serverless] Fix auto ops URL path suffix (#200192)\n\n## Summary\r\n\r\nUpdates the autoops URL path suffix.\r\n\r\n### Checklist\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: YulNaumenko <jo.naumenko@gmail.com>\r\nCo-authored-by: neptunian <sandra.gonzales@elastic.co>\r\nCo-authored-by: Sandra G <neptunian@users.noreply.github.com>","sha":"f4d74ec4a8a336264f4e37a07b38bcd524bfad8e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200192","number":200192,"mergeCommit":{"message":"[DataUsage][Serverless] Fix auto ops URL path suffix (#200192)\n\n## Summary\r\n\r\nUpdates the autoops URL path suffix.\r\n\r\n### Checklist\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: YulNaumenko <jo.naumenko@gmail.com>\r\nCo-authored-by: neptunian <sandra.gonzales@elastic.co>\r\nCo-authored-by: Sandra G <neptunian@users.noreply.github.com>","sha":"f4d74ec4a8a336264f4e37a07b38bcd524bfad8e"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Updates the autoops URL path suffix. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: YulNaumenko <jo.naumenko@gmail.com> Co-authored-by: neptunian <sandra.gonzales@elastic.co> Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the autoops URL path suffix.
Checklist