Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove close buttons from Saved Object relationship and Index Management flyouts #20043

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

cjcenizal
Copy link
Contributor

Addresses changes introduced by #20005.

No more close button in index management:

image

I removed the entire bottom bar from the saved object relationship flyout because there would be nothing in it:

image

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal merged commit 89e7266 into elastic:master Jun 20, 2018
@cjcenizal cjcenizal deleted the management-flyout-close-buttons branch June 20, 2018 04:07
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 20, 2018
cjcenizal added a commit that referenced this pull request Jun 20, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants